Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions apps/server/src/kin/dreaming/DreamIsolation.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
import { assert, it } from "@effect/vitest";
import {
ClaudeSettings,
ProviderInstanceId,
ProviderSessionId,
ThreadId,
} from "@t3tools/contracts";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as Schema from "effect/Schema";

import * as ClaudeAdapterV2 from "../../orchestration-v2/Adapters/ClaudeAdapterV2.ts";
import * as DreamIsolation from "./DreamIsolation.ts";

const options = ClaudeAdapterV2.makeClaudeQueryOptions({
modelSelection: {
instanceId: ProviderInstanceId.make("claudeAgent"),
model: "claude-sonnet-4-6",
},
nativeThreadId: "native",
resume: false,
cwd: "/dream",
attachmentsDir: "/attachments",
settings: Schema.decodeSync(ClaudeSettings)({
launchArgs: "--permission-mode bypassPermissions --mcp-config /mcp.json --add-dir /home",
}),
sdkSettings: {
permissions: { allow: ["Bash(curl:*)", "WebFetch"] },
alwaysThinkingEnabled: true,
},
mcpServers: { t3: { type: "http", url: "http://127.0.0.1/mcp" } },
allowedTools: ["mcp__t3__t3_thread_launch"],
permissionMode: "acceptEdits",
});

const canUseTool: NonNullable<ClaudeAdapterV2.ClaudeAgentSdkQueryOptions["canUseTool"]> = () =>
Promise.resolve({ behavior: "deny", message: "declined" });

it.effect("a dream query loads no user config, MCP or shell and edits only its checkout", () =>
Effect.gen(function* () {
const opened: Array<ClaudeAdapterV2.ClaudeAgentSdkQueryOptions> = [];
const base = Layer.succeed(
ClaudeAdapterV2.ClaudeAgentSdkQueryRunner,
ClaudeAdapterV2.ClaudeAgentSdkQueryRunner.of({
allocateSessionId: Effect.succeed("session"),
open: (input) =>
Effect.sync(() => opened.push(input.options)).pipe(
Effect.andThen(Effect.die("unused session")),
),
forkSession: () => Effect.die("unused fork"),
subagentLaunchToolUseId: () => Effect.die("unused lookup"),
assertComplete: Effect.void,
}),
);
yield* Effect.gen(function* () {
const runner = yield* ClaudeAdapterV2.ClaudeAgentSdkQueryRunner;
const open = (threadId: string) =>
runner
.open({
threadId: ThreadId.make(threadId),
providerSessionId: ProviderSessionId.make("session"),
options,
})
.pipe(Effect.exit);
yield* open("kin-dream:dream_20261108_fixture:extract");
yield* open("thread-1");
// Anyone can name a thread with the prefix, so the wrapper must never widen its mode.
yield* runner
.open({
threadId: ThreadId.make("kin-dream:spoofed"),
providerSessionId: ProviderSessionId.make("session"),
options: { ...options, permissionMode: "default", canUseTool, hooks: {} },
})
.pipe(Effect.exit);
}).pipe(Effect.provide(DreamIsolation.claudeQueryRunner(base)));

const [dream, other, spoofed] = opened;
assert.deepStrictEqual(
Object.keys(dream ?? {}).filter((key) => !DreamIsolation.dreamOptionFields.has(key)),
[],
);
assert.strictEqual(spoofed?.permissionMode, "default");
assert.strictEqual(spoofed?.canUseTool, canUseTool);
assert.isUndefined(spoofed?.hooks);
assert.strictEqual(options.permissionMode, "bypassPermissions");
assert.strictEqual(other, options);
assert.strictEqual(dream?.permissionMode, "acceptEdits");
assert.deepStrictEqual(dream?.settingSources, []);
assert.strictEqual(dream?.strictMcpConfig, true);
assert.deepStrictEqual(dream?.tools, DreamIsolation.dreamTools);
assert.deepStrictEqual(dream?.disallowedTools, ["Bash", "WebFetch", "WebSearch"]);
assert.isUndefined(dream?.mcpServers);
assert.isUndefined(dream?.allowedTools);
assert.isUndefined(dream?.additionalDirectories);
assert.deepStrictEqual(dream?.settings, {
alwaysThinkingEnabled: true,
showThinkingSummaries: true,
});
assert.deepStrictEqual(dream?.extraArgs, { "thinking-display": "summarized" });
assert.strictEqual(dream?.cwd, "/dream");
}),
);
119 changes: 119 additions & 0 deletions apps/server/src/kin/dreaming/DreamIsolation.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";

import * as ClaudeAdapterV2 from "../../orchestration-v2/Adapters/ClaudeAdapterV2.ts";

export const threadPrefix = "kin-dream:";
export const dreamTools = ["Read", "Edit", "Write", "Glob", "Grep"];
const blockedTools = ["Bash", "WebFetch", "WebSearch"];
/** Flags that change who approves a tool call; a dream refuses an instance launched with one. */
export const permissionFlag = /permission|dangerously|^allowed-?tools$/i;
// Flag settings load whatever settingSources says, so only model-selection keys survive.
const keptSettings = new Set([
"alwaysThinkingEnabled",
"fastMode",
"ultracode",
"showThinkingSummaries",
"autoCompactWindow",
]);

// Modes that already ask at least as often as acceptEdits; anything wider is narrowed to it.
const narrowModes = new Set<string>(["default", "plan", "dontAsk", "acceptEdits"]);

/**
* Dream material is untrusted, so a dream query loads no user, project or flag config and no MCP server,
* and its only tools read and edit the checkout. Approvals for anything else reach DreamSession, which declines.
*/
const isolateClaudeDream = (
options: ClaudeAdapterV2.ClaudeAgentSdkQueryOptions,
): ClaudeAdapterV2.ClaudeAgentSdkQueryOptions => {
const {
mcpServers: _mcpServers,
allowedTools: _allowedTools,
additionalDirectories: _additionalDirectories,
allowDangerouslySkipPermissions: _skip,
hooks: _hooks,
plugins: _plugins,
agents: _agents,
projectConfigRoot: _projectConfigRoot,
toolAliases: _toolAliases,
permissionPromptToolName: _permissionPromptToolName,
permissionPrompts: _permissionPrompts,
managedSettings: _managedSettings,
agent: _agent,
skills: _skills,
sandbox: _sandbox,
pluginDelivery: _pluginDelivery,
fallbackModel: _fallbackModel,
executable: _executable,
spawnClaudeCodeProcess: _spawn,
forkSession: _forkSession,
settings,
extraArgs,
permissionMode,
...rest
} = options;
const kept =
typeof settings === "object" && settings !== null
? Object.fromEntries(Object.entries(settings).filter(([key]) => keptSettings.has(key)))
: {};
const thinking = extraArgs?.["thinking-display"];
return {
...rest,
// The prefix is not reserved, so the wrapper may narrow a thread's mode but never widen it.
permissionMode: narrowModes.has(permissionMode) ? permissionMode : "acceptEdits",
settingSources: [],
strictMcpConfig: true,
tools: dreamTools,
disallowedTools: blockedTools,
...(Object.keys(kept).length === 0 ? {} : { settings: kept }),
...(thinking === undefined ? {} : { extraArgs: { "thinking-display": thinking } }),
};
};

/** Every field a dream query may carry; the test fails if the adapter starts passing anything else. */
export const dreamOptionFields = new Set([
"model",
"effort",
"thinking",
"includePartialMessages",
"resume",
"sessionId",
"resumeSessionAt",
"canUseTool",
"onUserDialog",
"onElicitation",
"supportedDialogKinds",
"pathToClaudeCodeExecutable",
"env",
"cwd",
"systemPrompt",
"permissionMode",
"settingSources",
"strictMcpConfig",
"tools",
"disallowedTools",
"settings",
"extraArgs",
]);

/** Wraps the Claude query runner; a no-op for every thread that is not a Kin dream. */
export const claudeQueryRunner = <E, R>(
base: Layer.Layer<ClaudeAdapterV2.ClaudeAgentSdkQueryRunner, E, R>,
) =>
Layer.effect(
ClaudeAdapterV2.ClaudeAgentSdkQueryRunner,
Effect.gen(function* () {
const runner = yield* ClaudeAdapterV2.ClaudeAgentSdkQueryRunner;
return ClaudeAdapterV2.ClaudeAgentSdkQueryRunner.of({
...runner,
open: Effect.fn("KinDreamIsolation.open")(function* (input) {
return yield* runner.open(
input.threadId.startsWith(threadPrefix)
? { ...input, options: isolateClaudeDream(input.options) }
: input,
);
}),
});
}),
).pipe(Layer.provide(base));
Loading