Repository navigation
feat(kin): push the right person for each chat, with mute, badge and quiet hours #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
83f89a3
feat(kin): push the right person for each chat, with mute, badge and …
GLDRoger 8ed188f
test(contracts): round-trip the chat mute input
GLDRoger 43c1e9c
test(mobile): route a lead's DM and a group push to their chats
GLDRoger 8a9eec2
test(kin): type the push alert helper
GLDRoger 29d2d02
Merge kin into kin-w3-3-push
GLDRoger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
apps/mobile/src/features/chats/notifications/KinBadgeSync.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { kinBadgeCount, type KinInboxState } from "@t3tools/client-runtime/kin/kinInboxModel"; | ||
| import * as Notifications from "expo-notifications"; | ||
| import { useEffect } from "react"; | ||
| import { Platform } from "react-native"; | ||
|
|
||
| /** | ||
| * Keeps the app icon's badge in step with the inbox while a chat is open, so reading a chat | ||
| * clears what the host's last push counted. Pushes set it again whenever the app is closed. | ||
| */ | ||
| export function KinBadgeSync(props: { readonly inbox: KinInboxState | null }) { | ||
| const count = props.inbox === null ? null : kinBadgeCount(props.inbox); | ||
| // oxlint-disable-next-line t3code/no-unreasoned-state-sync -- the icon badge lives in the OS, outside React | ||
| useEffect(() => { | ||
| if (count === null || Platform.OS !== "ios") return; | ||
| void Notifications.setBadgeCountAsync(count).catch((cause: unknown) => | ||
| console.warn("Setting the Kin badge failed", cause), | ||
| ); | ||
| }, [count]); | ||
| return null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS, if the app is opened to the chat list without mounting a chat screen, incoming Kin pushes do not update the icon badge: the app-wide
foregroundNotificationBehaviorexplicitly returnsshouldSetBadge: false, and the onlyKinBadgeSyncinstance is mounted here insideKinLiveChat. The inbox can therefore receive new unread messages while the OS badge retains its previous count, including after the user backgrounds the app. Synchronize the badge from an app-level live inbox, or permit Kin notification badges in the foreground handler, rather than requiring a chat screen to have been opened.Useful? React with 👍 / 👎.