Skip to content

Fix QGIS 4 compatibility #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koebi merged 7 commits into from
Jun 10, 2026
+19 −5
Merged

Fix QGIS 4 compatibility #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ceb5b2b
fix: remove Qt6 support flag from metadata
merydian May 27, 2026
0ede339
fix: restore qgisMaximumVersion in metadata
merydian May 27, 2026
d37a0e8
fix: add pyqt6-check job to GitHub Actions workflow
merydian May 27, 2026
61e960d
test: adapt layer feature count
koebi May 28, 2026
dc403be
CI: run test on 3.X, LTR, 4.X, latest
koebi Jun 10, 2026
846d4f6
CI: fix identifier name
koebi Jun 10, 2026
6de8e20
CI: install pytest via apt
koebi Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ on:
push:

jobs:
pyqt6-check:
uses: opengisch/qgis-plugin-ci/.github/workflows/pyqt6_test.yml@master
with:
plugin_path: ORSTools

test_3_16:
runs-on: ubuntu-latest
steps:
Expand All @@ -15,13 +20,22 @@ jobs:
docker run -v ${GITHUB_WORKSPACE}:/src -w /src qgis/qgis:release-3_16 sh -c 'apt-get -y update && apt-get -y install xvfb && export ORS_API_KEY=${{ secrets.ORS_API_KEY }} && pip install -U pytest && xvfb-run -a pytest'
env:
DOCKER_IMAGE: ${{ steps.docker-build.outputs.FULL_IMAGE_NAME }}
test_3_22:
test_ltr:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run test LTR
run: |
docker run -v ${GITHUB_WORKSPACE}:/src -w /src qgis/qgis:ltr-trixie sh -c 'apt-get -y update && apt-get -y install xvfb && export ORS_API_KEY=${{ secrets.ORS_API_KEY }} && export DISPLAY=:0.0 && apt install python3-pytest && xvfb-run -a pytest'
env:
DOCKER_IMAGE: ${{ steps.docker-build.outputs.FULL_IMAGE_NAME }}
test_4_0:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run test 3.22
- name: Run test 4.0
run: |
docker run -v ${GITHUB_WORKSPACE}:/src -w /src qgis/qgis:release-3_22 sh -c 'apt-get -y update && apt-get -y install xvfb && export ORS_API_KEY=${{ secrets.ORS_API_KEY }} && export DISPLAY=:0.0 && pip install -U pytest && xvfb-run -a pytest'
docker run -v ${GITHUB_WORKSPACE}:/src -w /src qgis/qgis:4.0 sh -c 'apt-get -y update && apt-get -y install xvfb && export ORS_API_KEY=${{ secrets.ORS_API_KEY }} && export PYTHONPATH=/usr/share/qgis/python && apt install python3-pytest && xvfb-run -a pytest'
env:
DOCKER_IMAGE: ${{ steps.docker-build.outputs.FULL_IMAGE_NAME }}
test_latest:
Expand Down
2 changes: 1 addition & 1 deletion ORStools/metadata.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[general]
name=ORS Tools
qgisMinimumVersion=3.4.8
qgisMaximumVersion=4.99
description=openrouteservice routing, isochrones and matrix calculations for QGIS
supportsQt6=True

version=2.1.0
author=HeiGIT gGmbH
Expand Down
2 changes: 1 addition & 1 deletion tests/test_gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ def test_custom_endpoints(self):
self.assertEqual(settings_directions_endpoint, "directions")

layer = proc.get_directions_points_layer()
self.assertAlmostEqual(layer.featureCount(), 93, delta=3)
self.assertAlmostEqual(layer.featureCount(), 97, delta=3)

self.assertEqual(
"POINT(8.67251100000000008 49.39887900000000087)",
Expand Down
Loading