Skip to content

fix(web): make chat app icons theme-aware #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobleer merged 1 commit into from
Aug 29, 2026
Merged

fix(web): make chat app icons theme-aware #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions src/web-ui/src/app/components/NavPanel/NavPanel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,10 +1638,9 @@ $_section-header-height: 22px;
line-height: 1.25;
}

// Attached remote parties are shown as one badge per device kind in the
// connection-live green the workspace list already teaches in this panel. The
// number lives inside a badge, so twenty attached hosts occupy the same width
// as one and no state sentence sits in permanent navigation chrome.
// Attached remote parties are shown once per device kind. Message-app marks
// stay unframed and inherit the theme foreground; connection state is already
// communicated by the device overview rather than by recoloring the brand.
.bitfun-nav-panel__footer-device-status-attached {
display: flex;
flex-shrink: 0;
Expand All @@ -1665,17 +1664,9 @@ $_section-header-height: 22px;
line-height: 1;

&[data-bf-device-kind='message-app'] {
border-color: color-mix(
in srgb,
var(--bf-appearance-token-color-success) 24%,
var(--bf-appearance-token-border-subtle)
);
background: color-mix(
in srgb,
var(--bf-appearance-token-color-success) 9%,
var(--bf-appearance-token-element-bg-subtle)
);
color: var(--bf-appearance-token-color-success);
border: 0;
background: transparent;
color: var(--bf-appearance-token-color-text-primary);
}
}

Expand Down Expand Up @@ -2238,12 +2229,8 @@ $_section-header-height: 22px;
}

&[data-bf-device-kind='message-app'] .bitfun-device-overview__device-icon {
background: color-mix(
in srgb,
var(--bf-appearance-token-color-success) 10%,
var(--bf-appearance-token-element-bg-subtle)
);
color: var(--bf-appearance-token-color-success);
background: transparent;
color: var(--bf-appearance-token-color-text-primary);
}

strong {
Expand Down
2 changes: 1 addition & 1 deletion src/web-ui/src/app/components/RemoteConnectDialog/ChatAppBrandIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface ChatAppBrandIconProps {

/**
* Monochrome contours of the actual chat-app marks. The SVGs intentionally
* inherit color from the surrounding identity badge so they work in every
* inherit color from the surrounding UI so they work in every
* theme without replacing the recognizable brand silhouettes.
* References: telegram.org/tour/screenshots, feishu.cn, and the CC0
* simple-icons WeChat/Telegram vectors.
Expand Down
39 changes: 39 additions & 0 deletions src/web-ui/src/app/components/RemoteConnectDialog/RemoteConnectDialog.contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ const deviceStatusControlSource = readFileSync(
new URL('../NavPanel/components/DeviceStatusControl.tsx', import.meta.url),
'utf8',
);
const navPanelStyleSource = readFileSync(
new URL('../NavPanel/NavPanel.scss', import.meta.url),
'utf8',
);
const accountPanelSource = readFileSync(
new URL('./AccountPanel.tsx', import.meta.url),
'utf8',
Expand Down Expand Up @@ -101,6 +105,32 @@ describe('Remote Connect safety contracts', () => {
});

it('uses the real monochrome app marks for every chat provider', () => {
const overviewBrandStyle = dialogStyleSource.slice(
dialogStyleSource.indexOf('.bitfun-remote-connect__chat-brand-item'),
dialogStyleSource.indexOf(
"[data-bf-component='remote-connect-dialog'][data-bf-part='overviewAction'][data-bf-group='account']",
),
);
const identityBrandStyle = dialogStyleSource.slice(
dialogStyleSource.indexOf('.bitfun-remote-connect__bot-identity-icon'),
dialogStyleSource.indexOf('.bitfun-remote-connect__bot-identity-title'),
);
const connectedBrandStyle = dialogStyleSource.slice(
dialogStyleSource.indexOf('.bitfun-remote-connect__connected-app-icon'),
dialogStyleSource.indexOf('.bitfun-remote-connect__connected-app-copy'),
);
const footerMessageBrandStyle = navPanelStyleSource.slice(
navPanelStyleSource.indexOf("&[data-bf-device-kind='message-app'] {"),
navPanelStyleSource.indexOf('.bitfun-nav-panel__footer-device-status-attached-count'),
);
const overviewMessageBrandStart = navPanelStyleSource.indexOf(
"&[data-bf-device-kind='message-app'] .bitfun-device-overview__device-icon {",
);
const overviewMessageBrandStyle = navPanelStyleSource.slice(
overviewMessageBrandStart,
navPanelStyleSource.indexOf(' strong {', overviewMessageBrandStart),
);

expect(dialogSource).toContain('<ChatAppBrandIcon app={botTab} size={28} />');
expect(dialogSource).toContain('bitfun-remote-connect__chat-brand-group');
expect(dialogSource).toContain('<ChatAppBrandIcon app={brand} size={15} />');
Expand All @@ -110,6 +140,15 @@ describe('Remote Connect safety contracts', () => {
expect(chatAppBrandIconSource.match(/fill="currentColor"/g)).toHaveLength(5);
expect(deviceStatusControlSource).toContain('chatAppBrandFromIdentity(identity)');
expect(deviceStatusControlSource).toContain('<ChatAppBrandIcon app={chatApp} size={size} />');
expect(overviewBrandStyle).toContain('border: 0');
expect(overviewBrandStyle).toContain('background: transparent');
expect(identityBrandStyle).not.toContain('background:');
expect(connectedBrandStyle).not.toContain('background:');
expect(footerMessageBrandStyle).toContain('border: 0');
expect(footerMessageBrandStyle).toContain('background: transparent');
expect(footerMessageBrandStyle).toContain('--bf-appearance-token-color-text-primary');
expect(overviewMessageBrandStyle).toContain('background: transparent');
expect(overviewMessageBrandStyle).toContain('--bf-appearance-token-color-text-primary');
expect(dialogSource).not.toContain('<Send size={28} />');
expect(dialogSource).not.toContain('<MessageSquareText size={28} />');
expect(dialogSource).not.toContain('<MessagesSquare size={28} />');
Expand Down
32 changes: 5 additions & 27 deletions src/web-ui/src/app/components/RemoteConnectDialog/RemoteConnectDialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,19 +273,9 @@
display: inline-flex;
align-items: center;
justify-content: center;
border: var(--bf-border-width-default) solid var(--bf-color-border-subtle);
border-radius: var(--bf-radius-base);
background: var(--bf-color-surface-subtle);
color: var(--bf-color-content-secondary);

&[data-connected='true'] {
background: color-mix(
in srgb,
var(--bf-color-accent-default) 12%,
var(--bf-color-surface-panel)
);
color: var(--bf-color-accent-default);
}
border: 0;
background: transparent;
color: var(--bf-color-content-primary);
}

[data-bf-component='remote-connect-dialog'][data-bf-part='overviewAction'][data-bf-group='account'] {
Expand Down Expand Up @@ -632,13 +622,7 @@
width: 60px;
height: 60px;
margin-bottom: 16px;
border-radius: var(--bf-radius-pill);
background: color-mix(
in srgb,
var(--bf-color-accent-default) 10%,
var(--bf-color-surface-panel)
);
color: var(--bf-color-accent-default);
color: var(--bf-color-content-primary);
}

.bitfun-remote-connect__bot-identity-title {
Expand Down Expand Up @@ -858,13 +842,7 @@
display: inline-flex;
align-items: center;
justify-content: center;
border-radius: var(--bf-radius-lg);
background: color-mix(
in srgb,
var(--bf-color-accent-default) 10%,
var(--bf-color-surface-panel)
);
color: var(--bf-color-accent-default);
color: var(--bf-color-content-primary);
}

.bitfun-remote-connect__connected-app-copy {
Expand Down
Loading