Skip to content

fix(test): drop quoted powershell sleep scripts in terminal exec tests (light-tested) #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1688mengdie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): drop quoted powershell sleep scripts in terminal exec tests (light-tested) #2655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/crates/services/terminal/src/exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,7 +1947,7 @@ mod tests {
async fn delayed_poll_returns_unread_output_after_process_exit() {
let manager = ExecProcessManager::default();
#[cfg(windows)]
let script = "echo first & powershell -NoProfile -Command \"Start-Sleep -Milliseconds 250\" & echo second";
let script = "echo first & powershell -NoProfile -Command Start-Sleep -Milliseconds 250 & echo second";
#[cfg(not(windows))]
let script = "echo first; sleep 0.25; echo second";

Expand Down Expand Up @@ -1993,7 +1993,7 @@ mod tests {
let manager = ExecProcessManager::default();
let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel();
#[cfg(windows)]
let script = "echo lifecycle_first & powershell -NoProfile -Command \"Start-Sleep -Milliseconds 250\" & echo lifecycle_second";
let script = "echo lifecycle_first & powershell -NoProfile -Command Start-Sleep -Milliseconds 250 & echo lifecycle_second";
#[cfg(not(windows))]
let script = "echo lifecycle_first; sleep 0.25; echo lifecycle_second";

Expand Down Expand Up @@ -2096,7 +2096,7 @@ mod tests {
async fn tty_poll_after_process_exit_returns_exit_code() {
let manager = ExecProcessManager::default();
#[cfg(windows)]
let script = "echo tty_first & powershell -NoProfile -Command \"Start-Sleep -Milliseconds 250\" & echo tty_second";
let script = "echo tty_first & powershell -NoProfile -Command Start-Sleep -Milliseconds 250 & echo tty_second";
#[cfg(not(windows))]
let script = "echo tty_first; sleep 0.25; echo tty_second";

Expand Down Expand Up @@ -2243,8 +2243,7 @@ mod tests {
async fn control_kill_terminates_running_pipe_session() {
let manager = ExecProcessManager::default();
#[cfg(windows)]
let script =
"echo before_kill & powershell -NoProfile -Command \"Start-Sleep -Seconds 30\"";
let script = "echo before_kill & powershell -NoProfile -Command Start-Sleep -Seconds 30";
#[cfg(not(windows))]
let script = "echo before_kill; sleep 30";

Expand Down