Skip to content

chore(deps): resolve Dependabot alerts for minimatch and node-forge - #17

Merged
G-man3207 merged 2 commits into
mainfrom
chore/fix-github-security-alerts
Nov 13, 2026
Merged

G-man3207 merged 2 commits into
mainfrom
chore/fix-github-security-alerts

Conversation

@G-man3207

@G-man3207 G-man3207 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Resolves 11 of the 12 open Dependabot alerts on this repository.

Package Change Alerts resolved
minimatch 10.2.5 → 11.0.8 via npm overrides #62 (GHSA-g3hv-75wg-m249)
node-forge 1.4.0 → 1.4.3 (lockfile update within @devicefarmer/adbkit's ^1.3.1 range) #34, #50, #52, #53, #54, #55, #58, #59, #60

Why an override for minimatch?

eslint@10 and @eslint/config-array@0.23.5 both declare minimatch: ^10.2.4, so no lockfile-only update can reach the patched 11.0.1+ line. The override "minimatch@^10.2.4": "^11.0.8" pins only the vulnerable v10 requests — the unrelated minimatch@3.1.5 instances (under addons-linter's eslint@9, @eslint/eslintrc, multimatch) are untouched. minimatch@11 requires node 20 || >=22; CI pins Node 20. ✅

node-forge

web-ext → @devicefarmer/adbkit declares ^1.3.1, so 1.4.3 (latest, includes the 1.4.2 fixes from #16) satisfies the existing range — pure lockfile refresh. Supersedes #16.

deepmerge (alert #49) — not fixable by upgrade

web-ext → addons-linter pins deepmerge: 4.3.1 exactly, and no patched release exists (4.3.1 is latest on npm). CVE-2026-93753 has been disputed and rejected by its CNA (VulnCheck) — Object.prototype is never modified in reproductions. It was dismissed with evidence rather than "fixed" by downgrading web-ext to 3.2.1 (what npm audit fix --force would do).

CI fix included

ubuntu-latest rotated to the 26.04 runner image this week and the pinned @playwright/test@1.59.1 cannot install Chromium there, failing Validate before any test runs. This is unrelated to the dependency changes above — everything this PR touches passed on the 26.04 runner (npm ci, ESLint with minimatch 11, web-ext lint, the Firefox smoke test). Validate is now pinned to ubuntu-24.04 until the Playwright bump tracked in #18.

Validation

  • npm run lint:strict ✅ (eslint works with minimatch 11)
  • npm run test:static ✅ 107 passed (idle machine)
  • node build-firefox.js + web-ext lint ✅ 0 errors (4 pre-existing warnings)
  • npm ls minimatch node-forge deepmerge shows only the intended version changes

Alert disposition

Alert Package Outcome
#62 minimatch Fixed here (override → 11.0.8)
#34, #50, #52–#60 node-forge Fixed here (1.4.3)
#49 deepmerge CVE-2026-93753 disputed & rejected by its CNA; dismissed as inaccurate with evidence

- minimatch 10.2.5 -> 11.0.8 via npm override (GHSA-g3hv-75wg-m249,
  Dependabot alert #62); eslint/@eslint/config-array request ^10.2.4
  so a plain update cannot reach the patched 11.x line
- node-forge 1.4.0 -> 1.4.3 within @devicefarmer/adbkit's ^1.3.1 range
  (Dependabot alerts #34, #50, #52-#60)
- deepmerge alert #49 (CVE-2026-93753) is handled separately: the CVE
  was disputed and rejected by its CNA and no patched release exists
ubuntu-latest moved to the 26.04 runner image in Nov 2026, and the
pinned @playwright/test 1.59.1 cannot install Chromium there
("Playwright does not support chromium on ubuntu26.04-x64"), which
fails the Validate workflow before any test runs.

Pin the job to ubuntu-24.04 (the image Validate was green on) until
Playwright is bumped to >= 1.65, the first line with ubuntu-26.04
support. That bump ships Chromium 158 and needs its own pass over the
timing-bound and popup-profile tests, so it stays out of this security
PR.
@G-man3207
G-man3207 merged commit bc61c01 into main Nov 13, 2026
2 checks passed
@G-man3207
G-man3207 deleted the chore/fix-github-security-alerts branch November 13, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant