Repository navigation
chore(deps): resolve Dependabot alerts for minimatch and node-forge - #17
Merged
Merged
Conversation
- minimatch 10.2.5 -> 11.0.8 via npm override (GHSA-g3hv-75wg-m249, Dependabot alert #62); eslint/@eslint/config-array request ^10.2.4 so a plain update cannot reach the patched 11.x line - node-forge 1.4.0 -> 1.4.3 within @devicefarmer/adbkit's ^1.3.1 range (Dependabot alerts #34, #50, #52-#60) - deepmerge alert #49 (CVE-2026-93753) is handled separately: the CVE was disputed and rejected by its CNA and no patched release exists
ubuntu-latest moved to the 26.04 runner image in Nov 2026, and the
pinned @playwright/test 1.59.1 cannot install Chromium there
("Playwright does not support chromium on ubuntu26.04-x64"), which
fails the Validate workflow before any test runs.
Pin the job to ubuntu-24.04 (the image Validate was green on) until
Playwright is bumped to >= 1.65, the first line with ubuntu-26.04
support. That bump ships Chromium 158 and needs its own pass over the
timing-bound and popup-profile tests, so it stays out of this security
PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 11 of the 12 open Dependabot alerts on this repository.
minimatch10.2.5→11.0.8via npmoverridesnode-forge1.4.0→1.4.3(lockfile update within@devicefarmer/adbkit's^1.3.1range)Why an override for minimatch?
eslint@10and@eslint/config-array@0.23.5both declareminimatch: ^10.2.4, so no lockfile-only update can reach the patched11.0.1+line. The override"minimatch@^10.2.4": "^11.0.8"pins only the vulnerable v10 requests — the unrelatedminimatch@3.1.5instances (underaddons-linter'seslint@9,@eslint/eslintrc,multimatch) are untouched.minimatch@11requiresnode 20 || >=22; CI pins Node 20. ✅node-forge
web-ext → @devicefarmer/adbkitdeclares^1.3.1, so1.4.3(latest, includes the1.4.2fixes from #16) satisfies the existing range — pure lockfile refresh. Supersedes #16.deepmerge (alert #49) — not fixable by upgrade
web-ext → addons-linterpinsdeepmerge: 4.3.1exactly, and no patched release exists (4.3.1is latest on npm). CVE-2026-93753 has been disputed and rejected by its CNA (VulnCheck) —Object.prototypeis never modified in reproductions. It was dismissed with evidence rather than "fixed" by downgradingweb-extto 3.2.1 (whatnpm audit fix --forcewould do).CI fix included
ubuntu-latestrotated to the 26.04 runner image this week and the pinned@playwright/test@1.59.1cannot install Chromium there, failing Validate before any test runs. This is unrelated to the dependency changes above — everything this PR touches passed on the 26.04 runner (npm ci, ESLint with minimatch 11,web-ext lint, the Firefox smoke test). Validate is now pinned toubuntu-24.04until the Playwright bump tracked in #18.Validation
npm run lint:strict✅ (eslint works with minimatch 11)npm run test:static✅ 107 passed (idle machine)node build-firefox.js+web-ext lint✅ 0 errors (4 pre-existing warnings)npm ls minimatch node-forge deepmergeshows only the intended version changesAlert disposition