add YamuxUnixSocket implementation for independent evolution of…#30
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a standalone YamuxUnixSocket transport implementation (duplicated from the existing unix_socket module) so the yamux daemon proxy’s transport/handshake behavior can evolve independently, and updates the crate/dependency versions accordingly.
Changes:
- Add
YamuxUnixSocketimplementation with connect/reconnect, handshake gating, and buffered writes. - Export
YamuxUnixSocketfromnginx_module’s public API. - Bump
nginx_moduleversion and loosen/upgrade dependency versions inCargo.toml(with correspondingCargo.lockupdates).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| nginx_module/src/yamux_unix_socket.rs | New yamux-specific Unix socket transport implementation with handshake + reconnect logic. |
| nginx_module/src/lib.rs | Exposes YamuxUnixSocket from the crate. |
| nginx_module/Cargo.toml | Bumps crate version and updates dependency version constraints. |
| Cargo.lock | Updates the resolved dependency graph to match the manifest changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix Inner::send only flushes pending write buffers when the state is Connected Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fix the reconnect backoff update can overshoot TIMEOUT_MS Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sockaddr_un::sun_path is a fixed-size C string buffer that should remain NUL-terminated Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… yamux transport