Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the integration test suite for the CLI tools (fastedge-build and fastedge-assets) by changing how test files resolve paths to package.json.
Changes:
- Removed the ES module
__dirnameshim (dirname(fileURLToPath(import.meta.url))) and its imports in two integration tests. - Left
package.jsonresolution still referencing__dirname, which will break test execution in ESM contexts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integration-tests/fastedge-build.test.js | Removes ESM __dirname setup but still uses __dirname to read package.json. |
| integration-tests/fastedge-assets.test.js | Removes ESM __dirname setup but still uses __dirname to read package.json. |
Comment on lines
1
to
4
| import { spawnSync } from 'node:child_process'; | ||
| import { readFileSync } from 'node:fs'; | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { join } from 'node:path'; | ||
|
|
Comment on lines
1
to
3
| import { readFileSync } from 'node:fs'; | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { join } from 'node:path'; | ||
|
|
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.