prevent tokio runtime queue overload under high load#154
Open
ruslanti wants to merge 2 commits into
Open
Conversation
…t instrumentation annotations
…eouts and extend error metrics
ruslanti
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce request backpressure under load by (1) adding more granular failure classifications for metrics and (2) making Redis (KV-store) operations fail fast so slow/unreachable Redis doesn’t stall tasks and allow in-flight work to pile up.
Changes:
- Extend
AppResult/metrics labeling with new outcomes (OVERLOADED,RATE_LIMITED,DISABLED) for clearer error reason breakdown in Prometheus. - Configure Redis
ConnectionManagerwith explicit short timeouts/retry/backoff to avoid long stalls on the request hot path. - Adjust
tracinginstrumentation and Redis warning log fields.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| crates/runtime/src/util/metrics.rs | Adds new AppResult → Prometheus “reason” label mappings. |
| crates/runtime/src/lib.rs | Introduces new AppResult variants (behind metrics feature) to represent overload/rate-limit/disabled outcomes. |
| crates/key-value-store/src/redis_impl.rs | Switches to ConnectionManagerConfig with explicit fail-fast timeouts and updates warning logs. |
| crates/key-value-store/src/lib.rs | Removes err from #[instrument(...)] on KV host methods (keeps ret). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
116
to
119
| .map_err(|error| { | ||
| tracing::warn!(cause=?error, "redis bf_exists"); | ||
| tracing::warn!(cause = ?error, key, item, "kv-store: redis bf_exists"); | ||
| Error::InternalError | ||
| }) |
qrdl
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.