Added mechanism to recover redis adter we degrade to in-memory [CLD-320]#461
Merged
maykcaldas merged 2 commits intoJun 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GlobalRateLimiter to optionally recover Redis-backed rate limiting after it has degraded to in-memory mode due to repeated Redis operation failures, using a configurable cooldown interval.
Changes:
- Added
RATE_LIMITER_REDIS_RECOVERY_INTERVALand tracked degradation time to enable periodic Redis recovery probes. - Implemented
_maybe_recover_redis()and integrated it into_test/_hitso recovery can occur automatically after cooldown. - Expanded unit tests to cover degradation timestamping and multiple recovery scenarios (skipped, succeeds, fails, cooldown not elapsed).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/lmi/src/lmi/rate_limiter.py | Adds recovery interval config, degradation timestamping, and Redis recovery probe logic invoked before rate limiter ops. |
| packages/lmi/tests/test_rate_limiter.py | Adds tests validating degradation timestamping and Redis recovery behavior across success/failure/skip cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maykcaldas
force-pushed
the
fix/add-redis-recover
branch
from
995db17 to
41225a3
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
maykcaldas
force-pushed
the
fix/add-redis-recover
branch
from
41225a3 to
5c88b04
Compare
maykcaldas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.