Repository navigation
Entities in Repeater-Werten erhalten (Backport #463), Release 9.5.3 - #465
Merged
Merged
Conversation
…kport #463), Release 9.5.3 Per Slot-Id kommt der Wert roh aus der Datenbank; decode() wandelte Entities vor dem json_decode() um. Ein " aus TinyMCE machte das JSON ungueltig (Modul leer), <h2> als Text kam als Markup zurueck. decode() und MBlockToRepeaterConverter::convertData() lesen jetzt zuerst roh und wandeln Entities nur als Rueckfall um; MFormValueHandler liest ohne htmlspecialchars_decode(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport von #463 auf die 9.5-Linie, Release 9.5.3.
Die 9.x-Linie hat dieselben Stellen, nur ohne
decodeRaw():MFormRepeaterHelper::decode()liest zuerst das rohe JSON, Entities werden nur noch als Rückfall umgewandelt (escapter Platzhalter'REX_VALUE[1]').decodeById()läuft darüber.MFormValueHandler::loadRexVars()liest ohnehtmlspecialchars_decode().MBlockToRepeaterConverter::convertData()liest zuerst roh ("im Inhalt ließ die Konvertierung sonst scheitern).#462 betrifft 9.x nicht: Die Tab-Leiste nutzt dort noch Floats,
pull-rightfunktioniert.9.x hat keine Testsuite. Im Container standalone geprüft: rohe Werte mit
"/&/<bleiben erhalten, der escapte Platzhalter mitnl2br()liefert dasselbe wie vorher, Konverter mit rohen und escapten Werten. Gegen den alten Code schlagen die beiden Entity-Fälle fehl.🤖 Generated with Claude Code