Skip to content

fix(mas): pass --publish never to build:mas like every other release script - #741

Merged
itsbkm merged 1 commit into
mainfrom
fix/mas-build-publish-never
Sep 13, 2026
Merged

itsbkm merged 1 commit into
mainfrom
fix/mas-build-publish-never

Conversation

@itsbkm

@itsbkm itsbkm commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • build:mas was the only build:*/release:* electron-builder script missing --publish never, unlike release:linux/release:mac/release:win.
  • In CI (publish-mas.yml), electron-builder's GitHub publish provider then requires a GH_TOKEN it has no reason to need for a Mac App Store build, failing the build outright: GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN".

Why

Found this while running the 3.8.6 Mac App Store publish for real — got past a separate, unrelated missing-provisioning-profile issue on the self-hosted runner, then hit this. Since fastlane/Fastfile's publish_mas lane runs npm run build:mas and then uploads the resulting .pkg itself via deliver, electron-builder never needs to publish anything to GitHub in this flow.

Test plan

  • Confirmed no test asserts the old script text
  • Re-run publish-mas.yml against a tag that includes this fix and confirm the build step passes

🤖 Generated with Claude Code

…script

Every release:* script (linux/mac/win) explicitly disables electron-builder's
GitHub publish step; build:mas was the one script invoking electron-builder
without it. In CI, electron-builder's GitHub publish provider requires a
GH_TOKEN even for a MAS build it should never try to publish anywhere, so
publish-mas.yml's build step failed outright: "GitHub Personal Access Token
is not set". Discovered while running the 3.8.6 Mac App Store build.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package.json is excluded by !package.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3d0ad81c-9640-49ba-b946-9433281e0bb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR prevents electron-builder from attempting an unnecessary GitHub publication during Mac App Store packaging.

  • Adds --publish never to the build:mas script.
  • Preserves the existing Fastlane flow that uploads the generated .pkg to App Store Connect separately.
  • Aligns MAS packaging with the repository’s other release scripts.

Confidence Score: 5/5

The PR appears safe to merge and fixes the unintended GitHub-token requirement without disabling the Mac App Store upload.

The changed option is supported by the installed tooling, follows existing release-script patterns, and affects only electron-builder publishing; the active MAS release path uploads its package separately through Fastlane.

Important Files Changed

Filename Overview
package.json Adds the supported --publish never option to the MAS electron-builder command without disrupting the separate Fastlane upload.

Reviews (1): Last reviewed commit: "fix(mas): pass --publish never to build:..." | Re-trigger Greptile

@itsbkm
itsbkm merged commit 4125622 into main Sep 13, 2026
16 checks passed
@itsbkm
itsbkm deleted the fix/mas-build-publish-never branch September 13, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant