fix(mas): pass --publish never to build:mas like every other release script - #741
Conversation
…script Every release:* script (linux/mac/win) explicitly disables electron-builder's GitHub publish step; build:mas was the one script invoking electron-builder without it. In CI, electron-builder's GitHub publish provider requires a GH_TOKEN even for a MAS build it should never try to publish anywhere, so publish-mas.yml's build step failed outright: "GitHub Personal Access Token is not set". Discovered while running the 3.8.6 Mac App Store build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR prevents electron-builder from attempting an unnecessary GitHub publication during Mac App Store packaging.
Confidence Score: 5/5The PR appears safe to merge and fixes the unintended GitHub-token requirement without disabling the Mac App Store upload. The changed option is supported by the installed tooling, follows existing release-script patterns, and affects only electron-builder publishing; the active MAS release path uploads its package separately through Fastlane.
|
| Filename | Overview |
|---|---|
| package.json | Adds the supported --publish never option to the MAS electron-builder command without disrupting the separate Fastlane upload. |
Reviews (1): Last reviewed commit: "fix(mas): pass --publish never to build:..." | Re-trigger Greptile
Summary
build:maswas the onlybuild:*/release:*electron-builder script missing--publish never, unlikerelease:linux/release:mac/release:win.publish-mas.yml), electron-builder's GitHub publish provider then requires aGH_TOKENit has no reason to need for a Mac App Store build, failing the build outright:GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN".Why
Found this while running the 3.8.6 Mac App Store publish for real — got past a separate, unrelated missing-provisioning-profile issue on the self-hosted runner, then hit this. Since
fastlane/Fastfile'spublish_maslane runsnpm run build:masand then uploads the resulting.pkgitself viadeliver, electron-builder never needs to publish anything to GitHub in this flow.Test plan
publish-mas.ymlagainst a tag that includes this fix and confirm the build step passes🤖 Generated with Claude Code