Fix duplicate Show more buttons and exposed CSS in code blocks - #10
Open
xrmb wants to merge 2 commits into
Open
Conversation
window.onload invoked shAll() and initCollapse() twice. This produced a second Show more button / fade overlay on every collapsible code block and blockquote, and the second syntax-highlighting pass corrupted the DOM and exposed internal CSS class names as visible text.
xrmb
force-pushed
the
fix-codeblock-display
branch
from
July 5, 2026 04:03
accb96c to
0085977
Compare
The regex-based highlighter was matching keywords, numbers, and attribute names inside the <span class="sh-*"> tags it had just created, producing visible fragments like class="sh-cm"> in the rendered code block. Split each replacement so it only applies to text outside existing HTML tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shAll()andinitCollapse()calls from thewindow.onloadhandler so long code blocks / blockquotes get exactly one Show more button and one fade overlay.<span class="sh-*">tags. This stops the highlighter from corrupting its own markup and exposing internal class names likeclass="sh-cm">as visible text in code blocks.Test plan
mdview.wlx64test.mdand confirm long code blocks show exactly one Show more button