Correct two stale comments in the docs sync - #5494
Merged
Merged
Conversation
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comments only, no behaviour change. Both were left inaccurate by #5473.
nuxt/lib/docs-sync.mjssaid the sibling-checkout precedence exists because "the releasepipeline depends on this". It does not: releases are cut by
release-publish.ymlinFlowFuse/flowfuse, which builds and npm-publishes and never touches docs or the website.
What actually relies on sibling resolution is the
Test Documentation with websitejob,which checks both repos out side by side. The old wording reads as though docs publishing
were part of the release pipeline.
scripts/sync_docs.mjssaid it exists "so CI can commit the result as a snapshot".#5473 removed the snapshot. It now runs so CI can resolve the docs before
npm install.Related Issue(s)
None.
Checklist