perf: cache the nuxt-og-image font download in build_website - #213
Open
dimitrieh wants to merge 3 commits into
Open
perf: cache the nuxt-og-image font download in build_website#213dimitrieh wants to merge 3 commits into
dimitrieh wants to merge 3 commits into
Conversation
FlowFuse/website's own test.yml cached two directories under a github.run_id key, so every run wrote a fresh entry. Measured on website main, the entry is 2.5MB, restores in 1s, and 53 of them were live. Build the forge took 1359s with it against 1394s without, so the render directory was buying nothing. This keeps only the font download, keyed on the lockfile that pins the module, so an unchanged lockfile hits exactly and saves nothing back.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the og-image cache step from FlowFuse/website's
test.ymlinto the shared build. FlowFuse/website#5515 replaces that job with a call to this workflow, and a job that uses a reusable workflow takes no steps of its own, so the step has to live here or not at all.Narrowed while porting. Measured on website
main:Build the forgeThe
github.run_idkey wrote a fresh entry every run, 53 of them live. Only the font download is worth keeping, so this caches that one directory keyed on the lockfile that pins the module: an unchanged lockfile hits exactly and saves nothing back.perf:means the release job movesbuild_website/v1, so website #5515 picks this up without a ref change.Happy to drop it entirely if you would rather the shared build carry no og-image cache.