-
Notifications
You must be signed in to change notification settings - Fork 89
Add tab presence support to track user activity across sessions #8182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bc151d0
Add tab presence support to track user activity across sessions
cstns faf91fd
Expand tab presence subscription topic to accept any message type
cstns 93e0f0d
Update tab presence topics to use `browser` namespace
cstns 23a6b59
Merge branch 'main' into feat/8158_store-browser-sessions-scaffolding
cstns 8e043bf
Update forge/comms/aclManager.js
Steve-Mcl 4f2fc4c
Enable shared subscriptions for tab presence topics
cstns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| const CACHE_NAME = 'browserSessions' | ||
| const CACHE_TTL = 135_000 // ~3x the 45s heartbeat interval | ||
| const CACHE_MAX = 10_000 | ||
|
|
||
| class BrowserSessionPresenceHandler { | ||
| constructor (app, client) { | ||
| this.app = app | ||
| this.client = client | ||
| this.cache = app.caches.createCache(CACHE_NAME, { max: CACHE_MAX, ttl: CACHE_TTL }) | ||
| this.setupEventHandlers() | ||
| } | ||
|
|
||
| setupEventHandlers () { | ||
| this.client.on('tab-presence', (msg) => this.handlePresence(msg)) | ||
| } | ||
|
|
||
| async handlePresence ({ userId, sessionId, messageType, payload }) { | ||
| const cacheKey = `${userId}:${sessionId}` | ||
|
|
||
| if (messageType === 'heartbeat') { | ||
| const existing = await this.cache.get(cacheKey) || {} | ||
| await this.cache.set(cacheKey, { | ||
| ...existing, | ||
| userId, | ||
| sessionId, | ||
| lastSeen: Date.now(), | ||
| visibility: payload.visibility || 'visible' | ||
| }) | ||
| } else if (messageType === 'context') { | ||
| const existing = await this.cache.get(cacheKey) || {} | ||
| await this.cache.set(cacheKey, { | ||
| ...existing, | ||
| userId, | ||
| sessionId, | ||
| lastSeen: Date.now(), | ||
| context: payload | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| async getSessionsByUser (userId) { | ||
| const allEntries = await this.cache.all() | ||
| const prefix = `${userId}:` | ||
| const sessions = [] | ||
| for (const [key, value] of Object.entries(allEntries)) { | ||
| if (key.startsWith(prefix)) { | ||
| sessions.push(value) | ||
| } | ||
| } | ||
| return sessions | ||
| } | ||
| } | ||
|
|
||
| module.exports = { | ||
| BrowserSessionPresenceHandler: (app, client) => new BrowserSessionPresenceHandler(app, client) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.