feature: Everything 1.5a support#4370
Conversation
…r handling Agent-Logs-Url: https://github.com/Flow-Launcher/Flow.Launcher/sessions/bfa04540-ad54-4f04-a7cf-fed5dbc06dcc Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
1 issue found across 12 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiV3.cs">
<violation number="1" location="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiV3.cs:111">
P2: Destroy the Everything3 client after incrementing run count; the current code leaks unmanaged client handles.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment |
|
@cubic-dev-ai review |
@jjw24 I have started the AI code review. It will take a few minutes to complete. |
jjw24
left a comment
There was a problem hiding this comment.
@VictoriousRaptor If cubic doesn't update the PR description after the review, could you do so please.
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs">
<violation number="1" location="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs:29">
P2: Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| throw new EngineNotAvailableException( | ||
| Enum.GetName(Settings.IndexSearchEngineOption.Everything)!, | ||
| Localize.flowlauncher_plugin_everything_15_resolution(), | ||
| Localize.flowlauncher_plugin_everything_15_unavailable(), |
There was a problem hiding this comment.
P2: Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs, line 29:
<comment>Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.</comment>
<file context>
@@ -20,12 +20,26 @@ public async ValueTask EnsureAvailableAsync(IEverythingApi api, CancellationToke
+ throw new EngineNotAvailableException(
+ Enum.GetName(Settings.IndexSearchEngineOption.Everything)!,
+ Localize.flowlauncher_plugin_everything_15_resolution(),
+ Localize.flowlauncher_plugin_everything_15_unavailable(),
+ Constants.EverythingErrorImagePath,
+ ClickToInstallEverythingAsync);
</file context>
| Localize.flowlauncher_plugin_everything_15_unavailable(), | |
| Localize.flowlauncher_plugin_everything_is_not_running(), |
There was a problem hiding this comment.
Do we still use x86? Maybe these can be removed?
There was a problem hiding this comment.
Do we still use x86? Maybe these can be removed?
maybe.
busy recently. i'm trying: |
@VictoriousRaptor I can help — what did you want me to do?
|
|
@cubic please update the PR description |
@VictoriousRaptor I can help — what did you want me to do?
|
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # .github/actions/spelling/expect.txt Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
🚀 Description
This PR introduces native support for Everything 1.5a (Alpha) within the Explorer Plugin.
Currently, Everything 1.5 Alpha operates on a separate named instance (
1.5a) and utilizes different IPC pipes to prevent conflicts with stable 1.4 installations. Because of this, Flow Launcher fails to detect the service out-of-the-box. Previously, the only way to resolve this was by asking users to manually addalpha_instance=0to theirEverything-1.5a.iniconfig file.This update refactors the Everything connection logic in the Explorer Plugin to actively detect and bind to the
1.5aIPC pipe, ensuring seamless file searching without requiring end-user configuration hacks.🔗 Related Issues
Flow.Launcher.Plugin.Explorerwith Everything (1.5a) #1769 - BUG: Incompatibility of plugin Flow.Launcher.Plugin.Explorer with Everything (1.5a)🛠️ Changes Made
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.