Skip to content

feature: Everything 1.5a support#4370

Open
VictoriousRaptor wants to merge 32 commits intodevfrom
everything-1.5-sdk
Open

feature: Everything 1.5a support#4370
VictoriousRaptor wants to merge 32 commits intodevfrom
everything-1.5-sdk

Conversation

@VictoriousRaptor
Copy link
Copy Markdown
Contributor

@VictoriousRaptor VictoriousRaptor commented Mar 21, 2026

🚀 Description

This PR introduces native support for Everything 1.5a (Alpha) within the Explorer Plugin.

Currently, Everything 1.5 Alpha operates on a separate named instance (1.5a) and utilizes different IPC pipes to prevent conflicts with stable 1.4 installations. Because of this, Flow Launcher fails to detect the service out-of-the-box. Previously, the only way to resolve this was by asking users to manually add alpha_instance=0 to their Everything-1.5a.ini config file.

This update refactors the Everything connection logic in the Explorer Plugin to actively detect and bind to the 1.5a IPC pipe, ensuring seamless file searching without requiring end-user configuration hacks.

🔗 Related Issues

🛠️ Changes Made

  • Instance Detection: Implemented logic to intelligently connect to the Everything 1.5a IPC named pipe if the standard 1.4 instance is not found.
  • Code Refactor: Cleaned up the Everything SDK integration and background service detection to accommodate multi-version environments.
  • UX Improvement: Removed the false-positive "Everything service is not running" warning for users who are running the 1.5a alpha natively.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@VictoriousRaptor VictoriousRaptor added this to the Future milestone Mar 21, 2026
@github-actions github-actions Bot modified the milestones: Future, 2.2.0 Mar 21, 2026
@prlabeler prlabeler Bot added the bug Something isn't working label Mar 21, 2026
@VictoriousRaptor VictoriousRaptor added enhancement New feature or request and removed bug Something isn't working labels Mar 22, 2026
@prlabeler prlabeler Bot added the bug Something isn't working label Mar 22, 2026

This comment was marked as outdated.

…r handling

Agent-Logs-Url: https://github.com/Flow-Launcher/Flow.Launcher/sessions/bfa04540-ad54-4f04-a7cf-fed5dbc06dcc

Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>

This comment was marked as off-topic.

@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review March 28, 2026 14:06
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiV3.cs">

<violation number="1" location="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiV3.cs:111">
P2: Destroy the Everything3 client after incrementing run count; the current code leaks unmanaged client handles.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiV3.cs Outdated
VictoriousRaptor and others added 2 commits April 4, 2026 20:04
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Apr 5, 2026

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.

@jjw24
Copy link
Copy Markdown
Member

jjw24 commented Apr 8, 2026

@cubic-dev-ai review

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Apr 8, 2026

@cubic-dev-ai review

@jjw24 I have started the AI code review. It will take a few minutes to complete.

Copy link
Copy Markdown
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VictoriousRaptor If cubic doesn't update the PR description after the review, could you do so please.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs">

<violation number="1" location="Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs:29">
P2: Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

throw new EngineNotAvailableException(
Enum.GetName(Settings.IndexSearchEngineOption.Everything)!,
Localize.flowlauncher_plugin_everything_15_resolution(),
Localize.flowlauncher_plugin_everything_15_unavailable(),
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAvailabilityService.cs, line 29:

<comment>Use the standard “Everything is not running” message in the non‑1.5 path; the current string reports a 1.5‑specific unavailability even when 1.5 support is disabled.</comment>

<file context>
@@ -20,12 +20,26 @@ public async ValueTask EnsureAvailableAsync(IEverythingApi api, CancellationToke
+                        throw new EngineNotAvailableException(
+                        Enum.GetName(Settings.IndexSearchEngineOption.Everything)!,
+                        Localize.flowlauncher_plugin_everything_15_resolution(),
+                        Localize.flowlauncher_plugin_everything_15_unavailable(),
+                        Constants.EverythingErrorImagePath,
+                        ClickToInstallEverythingAsync);
</file context>
Suggested change
Localize.flowlauncher_plugin_everything_15_unavailable(),
Localize.flowlauncher_plugin_everything_is_not_running(),
Fix with Cubic

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use x86? Maybe these can be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use x86? Maybe these can be removed?

maybe.

@jjw24 jjw24 changed the title feature: Everything 1.5 support feature: Everything 1.5a support Apr 8, 2026
@prlabeler prlabeler Bot added the enhancement New feature or request label Apr 8, 2026
@Jack251970 Jack251970 removed their request for review April 12, 2026 05:54
@VictoriousRaptor
Copy link
Copy Markdown
Contributor Author

VictoriousRaptor commented Apr 20, 2026

@VictoriousRaptor If cubic doesn't update the PR description after the review, could you do so please.

busy recently.

i'm trying:
@cubic-dev-ai please update the PR description

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Apr 20, 2026

@VictoriousRaptor If cubic doesn't update the PR description after the review, could you do so please.

busy recently.

try:
...

@VictoriousRaptor I can help — what did you want me to do?

  • Manage learnings: reply in the relevant thread and say @cubic add this to our learnings (I'll extract the learning from context). For delete/update, paste the learning link from Settings → AI review → Learnings.
  • Make a code change: @cubic fix this and push commits (or open a PR)
  • Ask a question: @cubic why is this needed?

@VictoriousRaptor
Copy link
Copy Markdown
Contributor Author

@cubic please update the PR description

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Apr 20, 2026

@cubic please update the PR description

@VictoriousRaptor I can help — what did you want me to do?

  • Manage learnings: reply in the relevant thread and say @cubic add this to our learnings (I'll extract the learning from context). For delete/update, paste the learning link from Settings → AI review → Learnings.
  • Make a code change: @cubic fix this and push commits (or open a PR)
  • Ask a question: @cubic why is this needed?

@VictoriousRaptor
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	.github/actions/spelling/expect.txt

Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

@copilot resolve the merge conflicts in this pull request

Done in f940414. The only conflict was .github/actions/spelling/expect.txt (deleted in dev when spellcheck was removed, modified in this branch) — resolved by accepting the deletion. The branch is now up to date with dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Refactor enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Incompatibility of plugin Flow.Launcher.Plugin.Explorer with Everything (1.5a) Add support for Everything v1.5a

5 participants