Skip to content

ci(fork-patches): add typecheck + serialized server CI lane (FLO-520) - #6

Closed
Fl0p wants to merge 1 commit into
fork-patchesfrom
flo-520-fork-patches-ci
Closed

ci(fork-patches): add typecheck + serialized server CI lane (FLO-520)#6
Fl0p wants to merge 1 commit into
fork-patchesfrom
flo-520-fork-patches-ci

Conversation

@Fl0p

@Fl0p Fl0p commented Jul 21, 2026

Copy link
Copy Markdown

What

Adds .github/workflows/fork-patches.yml — a minimal, self-contained CI lane for the fork-patches integration branch. Runs on push/pull_request to fork-patches:

  • Typecheckpnpm run typecheck (full pnpm -r typecheck + workspace-links preflight).
  • Serialized server testspnpm test:run:serialized, 4 shards, embedded-postgres, on x86 ubuntu-latest runners.

Uses --frozen-lockfile, which doubles as a lockfile-consistency check.

Why (FLO-520, follow-up from FLO-518)

pr.yml only triggers on pull_request -> master. A fork-patches -> master PR spans ~300 commits and carries pnpm-lock.yaml changes, so the pr.yml policy job's manual-lockfile-edit guard fails, and every needs:[policy] job — including the DB-backed verify_serialized_server suite — is skipped. Net effect: patches landing on fork-patches got no CI.

This lane deliberately does not re-run the pr.yml policy/lockfile-guard machinery; the committed pnpm-lock.yaml is authoritative on fork-patches.

Verification

  • YAML parses; jobs = typecheck, serialized_server (4 shards); triggers = push + PR on fork-patches.
  • pnpm run typecheck and pnpm test:run:serialized both exist in package.json and are the same commands proven green in release-verify.yml.
  • Step blocks mirror the proven release-verify.yml / pr.yml lanes.
  • Not runnable locally: maintainer host is ARM; these checks need x86 + embedded-postgres (the whole point of the ticket).

Note

paperclip is a special repo — merge needs board owner approval. Handing off rather than self-merging (CI config is review-required surface).

pr.yml only triggers on pull_request -> master, and a fork-patches -> master
PR spans ~300 commits and carries pnpm-lock.yaml changes, so the pr.yml policy
job's manual-lockfile-edit guard fails and every needs:[policy] job (including
the DB-backed verify_serialized_server suite) is skipped. Patches landing on
fork-patches therefore got no CI.

Add a self-contained fork-patches.yml that runs on push/PR to fork-patches:
full `pnpm run typecheck` and the embedded-postgres serialized server tests
(4 shards, mirroring the proven release-verify.yml lane) on x86 runners. Uses
--frozen-lockfile so it doubles as a lockfile-consistency check and skips the
pr.yml lockfile-guard machinery that does not apply to the integration branch.

Refs FLO-520 (follow-up from FLO-518).

Co-Authored-By: Daedalus <daedalus@agents.flopbut.local>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 23b67f05-6e10-46ff-a4d3-510c61abff4b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch flo-520-fork-patches-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fl0p

Fl0p commented Jul 21, 2026

Copy link
Copy Markdown
Author

Closing per board decision on FLO-520 (request_confirmation rejected): the fork-patches CI lane is not wanted. No changes landed on fork-patches; feature branch deleted.

@Fl0p Fl0p closed this Jul 21, 2026
@Fl0p
Fl0p deleted the flo-520-fork-patches-ci branch July 21, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant