ci(fork-patches): add typecheck + serialized server CI lane (FLO-520) - #6
ci(fork-patches): add typecheck + serialized server CI lane (FLO-520)#6Fl0p wants to merge 1 commit into
Conversation
pr.yml only triggers on pull_request -> master, and a fork-patches -> master PR spans ~300 commits and carries pnpm-lock.yaml changes, so the pr.yml policy job's manual-lockfile-edit guard fails and every needs:[policy] job (including the DB-backed verify_serialized_server suite) is skipped. Patches landing on fork-patches therefore got no CI. Add a self-contained fork-patches.yml that runs on push/PR to fork-patches: full `pnpm run typecheck` and the embedded-postgres serialized server tests (4 shards, mirroring the proven release-verify.yml lane) on x86 runners. Uses --frozen-lockfile so it doubles as a lockfile-consistency check and skips the pr.yml lockfile-guard machinery that does not apply to the integration branch. Refs FLO-520 (follow-up from FLO-518). Co-Authored-By: Daedalus <daedalus@agents.flopbut.local> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing per board decision on FLO-520 (request_confirmation rejected): the fork-patches CI lane is not wanted. No changes landed on fork-patches; feature branch deleted. |
What
Adds
.github/workflows/fork-patches.yml— a minimal, self-contained CI lane for thefork-patchesintegration branch. Runs onpush/pull_requesttofork-patches:pnpm run typecheck(fullpnpm -r typecheck+ workspace-links preflight).pnpm test:run:serialized, 4 shards, embedded-postgres, on x86ubuntu-latestrunners.Uses
--frozen-lockfile, which doubles as a lockfile-consistency check.Why (FLO-520, follow-up from FLO-518)
pr.ymlonly triggers onpull_request -> master. Afork-patches -> masterPR spans ~300 commits and carriespnpm-lock.yamlchanges, so thepr.ymlpolicyjob's manual-lockfile-edit guard fails, and everyneeds:[policy]job — including the DB-backedverify_serialized_serversuite — is skipped. Net effect: patches landing onfork-patchesgot no CI.This lane deliberately does not re-run the
pr.ymlpolicy/lockfile-guard machinery; the committedpnpm-lock.yamlis authoritative onfork-patches.Verification
typecheck,serialized_server(4 shards); triggers = push + PR onfork-patches.pnpm run typecheckandpnpm test:run:serializedboth exist inpackage.jsonand are the same commands proven green inrelease-verify.yml.release-verify.yml/pr.ymllanes.Note
paperclipis a special repo — merge needs board owner approval. Handing off rather than self-merging (CI config is review-required surface).