Skip to content

fix(meshy): derive download extension from URL pathname - #13

Closed
Fl0p wants to merge 1 commit into
mainfrom
flo-607-derive-download-ext-from-pathname
Closed

fix(meshy): derive download extension from URL pathname#13
Fl0p wants to merge 1 commit into
mainfrom
flo-607-derive-download-ext-from-pathname

Conversation

@Fl0p

@Fl0p Fl0p commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix extFromUrl() to parse the URL pathname basename instead of splitting the entire URL string on ., preventing TLD segments (e.g. io/x) from leaking into download filenames when the path has no extension.

Verification

node -e acceptance cases (all ok):

{"url":"https://cdn.meshy.io/x","got":"png","want":"png","ok":true}
{"url":"https://assets.meshy.ai/a/model.glb?X=1","got":"glb","want":"glb","ok":true}
{"url":"https://x.com/a.png#frag","got":"png","want":"png","ok":true}
{"url":"not-a-url","got":"fbx","want":"fbx","ok":true}
{"url":"/relative/path.obj","got":"glb","want":"glb","ok":true}
  • npm run docs:build — clean
  • node plugins/meshy/skills/meshy/scripts/meshy.mjs version — exactly one JSON object on STDOUT

Test plan

  • Acceptance cases above
  • docs build
  • version command output contract

Made with Cursor

Parse URL pathname basename instead of splitting the full URL string,
so TLD segments and hash fragments no longer leak into filenames.

Co-Authored-By: Soren <soren@agents.flopbut.local>
Co-Authored-By: Cursor Composer 2.5 <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Fl0p

Fl0p commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

self-merged under envelope (low-risk: localized extFromUrl bugfix), CI N/A (claude-review dead); verified locally at 1e63daa

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d16d849c-42ab-4899-ac6b-894b081147be


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fl0p Fl0p closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant