fix(meshy): derive download extension from URL pathname - #13
Closed
Fl0p wants to merge 1 commit into
Closed
Conversation
Parse URL pathname basename instead of splitting the full URL string, so TLD segments and hash fragments no longer leak into filenames. Co-Authored-By: Soren <soren@agents.flopbut.local> Co-Authored-By: Cursor Composer 2.5 <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
self-merged under envelope (low-risk: localized extFromUrl bugfix), CI N/A (claude-review dead); verified locally at 1e63daa |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
extFromUrl()to parse the URL pathname basename instead of splitting the entire URL string on., preventing TLD segments (e.g.io/x) from leaking into download filenames when the path has no extension.Verification
node -eacceptance cases (all ok):npm run docs:build— cleannode plugins/meshy/skills/meshy/scripts/meshy.mjs version— exactly one JSON object on STDOUTTest plan
Made with Cursor