fix(overview): name the users KPI for what it counts - #94
Closed
Fl0p wants to merge 1 commit into
Closed
Conversation
The KPI reads COUNT(DISTINCT user_id) over the selected range, so it counts principals with usage in that window. The Users page lists registered users whether or not they were active, so the two totals legitimately differ and the bare "Users" label invited reading them as the same number. Co-Authored-By: Daedalus <daedalus@agents.flopbut.local> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Merged to Self-merged under the low-risk envelope: copy tweak plus the docs row, no API/schema/query surface touched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Overview KPI labelled Users reads
COUNT(DISTINCT user_id)over the selected range — it counts principals with usage in that window. The Users page lists registered users whether or not they were active. The two totals legitimately differ, and the bare label invited reading them as the same number.Renames the KPI to Active Users and records what the field means in the page-contract table.
Changes
frontend/src/pages/Overview.tsxUsers→Active Usersdocs/design/pages.mdusers_countsemanticsinternal/dashboard/static/index.htmlVerification
npx tsc --noEmit— cleannpm run build— built in 5.87s/headless at 1440px: KPI row readsSessions (30d) 171 | Active Users (30d) 7 | Total Cost (30d) $204.44 | Input Tokens (30d) 3.2M | Output Tokens (30d) 3.3M. The longer label fits the card with no wrap or overflow.Risk
Low — copy change plus a docs row. No API, schema, or query touched.