Skip to content

fix(overview): name the users KPI for what it counts - #94

Closed
Fl0p wants to merge 1 commit into
mainfrom
flo-588-active-users-label
Closed

fix(overview): name the users KPI for what it counts#94
Fl0p wants to merge 1 commit into
mainfrom
flo-588-active-users-label

Conversation

@Fl0p

@Fl0p Fl0p commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The Overview KPI labelled Users reads COUNT(DISTINCT user_id) over the selected range — it counts principals with usage in that window. The Users page lists registered users whether or not they were active. The two totals legitimately differ, and the bare label invited reading them as the same number.

Renames the KPI to Active Users and records what the field means in the page-contract table.

Changes

File Change
frontend/src/pages/Overview.tsx KPI label UsersActive Users
docs/design/pages.md New contract row documenting users_count semantics
internal/dashboard/static/index.html Rebuilt asset hash

Verification

  • npx tsc --noEmit — clean
  • npm run build — built in 5.87s
  • Go binary built with embedded assets, seeded a throwaway instance (485 sessions / 25630 spans / 7 users), rendered / headless at 1440px: KPI row reads Sessions (30d) 171 | Active Users (30d) 7 | Total Cost (30d) $204.44 | Input Tokens (30d) 3.2M | Output Tokens (30d) 3.3M. The longer label fits the card with no wrap or overflow.

Risk

Low — copy change plus a docs row. No API, schema, or query touched.

The KPI reads COUNT(DISTINCT user_id) over the selected range, so it counts
principals with usage in that window. The Users page lists registered users
whether or not they were active, so the two totals legitimately differ and
the bare "Users" label invited reading them as the same number.

Co-Authored-By: Daedalus <daedalus@agents.flopbut.local>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eada03cf-ca0c-4810-aaff-66f5eb3852bb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fl0p

Fl0p commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Merged to main as 8dde221 via local squash (author and committer land as Daedalus, which gh pr merge --squash cannot do). CI was green on the PR head: Build & Test ✅, Smoke test ✅, VitePress docs ✅.

Self-merged under the low-risk envelope: copy tweak plus the docs row, no API/schema/query surface touched.

@Fl0p Fl0p closed this Aug 20, 2026
@Fl0p
Fl0p deleted the flo-588-active-users-label branch August 20, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant