fix(server): recover the results page when a scope filters everything out#82
Merged
Conversation
… out
On the served results page the scope bar only rendered when there were
results, so an include scope that matched nothing left a blank "No results"
page with no way to see or clear the scope that hid them. Re-searching kept
filtering to empty because the scope persisted invisibly.
The empty-results branch now renders the scope bar, attributes the emptiness
to the active scope ("No results match the '<scope>' scope for '<query>'"),
and offers a one-click "Clear scope" that posts an empty lens and returns to
the same query unfiltered. Owner-only, like the rest of the in-page controls.
Mirrors the desktop fix.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the served results page the scope bar only rendered when results existed. An include scope that matched nothing (e.g. "Recipes" on a
threejssearch) produced a blank "No results" page with no way to see or clear the scope that hid the results, and re-searching kept filtering to empty because the scope persisted invisibly.Fix
The empty-results branch now (for the loopback owner):
Mirrors the desktop fix (SearchMob-Desktop#88).
Verification
WebUiPersonalizationTestdrives a real loopback server with an active scope + empty provider and asserts the scope bar, the scope-attributed message, and the clear-scope control. ktlint + full unit suite green.🤖 Generated with Claude Code