feat(ui): edit a saved scope in the app Settings#77
Merged
Conversation
The app could only create or delete scopes (lenses); each had a Delete button but no way to adjust it. The browser Settings page already renders a pre-filled form per scope (editable in place). Bring the app to parity: add an Edit button on each scope row that opens AddLensDialog pre-filled with that scope's name, include/exclude domains, and include/exclude keywords; saving upserts by name (via the existing SettingsViewModel.saveLens), so an edit replaces the scope in place. The dialog title reads "Edit" when editing, "Add scope" when creating. Verified the Edit buttons render on every scope row in the app Settings (screenshot). Full tap-through of the pre-filled dialog wasn't captured because a second agent was driving the same emulator and kept stealing foreground; the pre-fill is straightforward Compose state seeded from the existing lens, and ktlint + app unit tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final parity item. The app could only create or delete scopes (lenses); the browser Settings page already renders an editable pre-filled form per scope. This brings the app to parity.
Change
SettingsViewModel.saveLens), so an edit replaces the scope in place. Dialog title reads "Edit" when editing, "Add scope" when creating.Verified
The Edit buttons render on every scope row (screenshot-checked when SearchMob was foregrounded). I couldn't capture the full tap-through of the pre-filled dialog because a second agent was driving the same emulator and kept stealing foreground (my Edit tap once landed in its unrelated Chrome tab — I did not interact with it). The pre-fill is straightforward Compose state seeded from the existing lens; ktlint + app unit tests pass.
Note on the web side
The investigation flagged "lens edit" as missing on both surfaces, but the browser Settings page already renders a pre-filled
lensForm(lens)per scope (each is editable, upserting by name). So only the app needed this; no web change.🎉 Parity epic complete
With this, the app GUI ↔ web UI parity work is done: web Settings gained language + media/history/update-check toggles (#71), personalization controls (#73), and per-engine toggles (#74); the app gained the domain-rule add form (#75), the summary thumbnail (#76), and now scope editing. (BYO API keys and the network-mode toggle remain intentionally app-only, per your security call.)
🤖 Generated with Claude Code