fix(gui): keep checking for updates while the window stays open#89
Merged
Conversation
The update check ran only on the first window show, so a release published after launch was never surfaced to a user who left the app open (no relaunch, no notification). It now also starts a recurring timer on first show that re-runs the throttled check while the window stays open. check_if_due keeps the ~daily throttle, so almost every tick does no network at all; this only bounds how long after a release the banner can lag, instead of never. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop update check fired only on the first window show (
showEvent), once per process, plus a ~daily throttle. A user who left the app open when a release published was never notified (this is how v26.06.05 was missed). The version-code comparison itself was correct.Fix
On first show, in addition to the launch check, start a recurring
QTimerthat re-runs the throttledcheck_if_duewhile the window stays open. The ~daily throttle means almost every tick is a no-op (no network); it just bounds the notification lag instead of leaving it at "never".Verification
🤖 Generated with Claude Code