fix: keep legacy 200/400 codes for older clients in schedule-related endpoints - #2429
Open
nhoening wants to merge 2 commits into
Open
fix: keep legacy 200/400 codes for older clients in schedule-related endpoints#2429nhoening wants to merge 2 commits into
nhoening wants to merge 2 commits into
Conversation
…endpoints Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Documentation build overview
6 files changed ·
|
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Flix6x
reviewed
Aug 19, 2026
|
|
||
| Default: ``None`` | ||
|
|
||
| FLEXMEASURES_LEGACY_SCHEDULEACCEPTED_STATUS_MAX_INCOMPATIBLE_CLIENT_VERSION |
Member
There was a problem hiding this comment.
I suggest introducing one less configuration setting, by combining the two:
FLEXMEASURES_LEGACY_SCHEDULEACCEPTED_STATUS: {"v2g-liberty-version": "0.9.1"}
This also makes it possible to have more than one entry for matching.
Better would be to match the version with the actual v2g-liberty version, and only use the fm-client version if that's the actual attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are users using flexmeasures-client before 0.9.2, and they will have trouble getting their schedules when we release v1.0.0.
We switched to the correct way of returning HTTP status 202 when the job is not done. An earlier version of FlexMeasures returned 503 and a "Retry-After" header. The client still supports this rather odd behavior.
documentation/changelog.rstHow to test