Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/api/urls/experiments.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@

from features.feature_states.views import (
delete_segment_override,
update_flag_v1,
update_flag_v2,
update_flag_option_a,
update_flag_option_b,
)

app_name = "experiments"

urlpatterns = [
path(
"environments/<str:environment_key>/update-flag-v1/",
update_flag_v1,
name="update-flag-v1",
update_flag_option_a,
name="update-flag-option-a",
),
path(
"environments/<str:environment_key>/update-flag-v2/",
update_flag_v2,
name="update-flag-v2",
update_flag_option_b,
name="update-flag-option-b",
),
path(
"environments/<str:environment_key>/delete-segment-override/",
Expand Down
35 changes: 14 additions & 21 deletions api/experimentation/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@
)
from features.models import FeatureState
from features.value_types import BOOLEAN, INTEGER, STRING
from features.versioning.dataclasses import FlagChangeSet
from features.versioning.dataclasses import FeatureValue, FlagChangeSetOptionA
from features.versioning.versioning_service import (
apply_feature_state_changes,
update_flag,
update_multivariate_values,
)
from integrations.flagsmith.client import get_openfeature_client
from segments.models import Condition, Segment, SegmentRule
Expand Down Expand Up @@ -593,19 +593,9 @@ def _get_live_rollout_override(experiment: Experiment) -> FeatureState | None:
)


def _update_live_feature_state(
feature_state: FeatureState, change_set: FlagChangeSet
def _update_rollout_in_place(
experiment: Experiment, change_set: FlagChangeSetOptionA
) -> None:
feature_state.enabled = change_set.enabled
feature_state.save()
feature_state.feature_state_value.set_value(
change_set.feature_state_value, change_set.type_
)
feature_state.feature_state_value.save()
update_multivariate_values(feature_state, change_set.multivariate_values)


def _update_rollout_in_place(experiment: Experiment, change_set: FlagChangeSet) -> None:
"""Write the rollout-segment override, keeping variant assignment stable.

Under v2 versioning, ``update_flag`` clones the override into a fresh feature
Expand All @@ -622,7 +612,12 @@ def _update_rollout_in_place(experiment: Experiment, change_set: FlagChangeSet)
if experiment.environment.use_v2_feature_versioning and (
override := _get_live_rollout_override(experiment)
):
_update_live_feature_state(override, change_set)
apply_feature_state_changes(
override,
enabled=change_set.enabled,
value=change_set.value,
multivariate_values=change_set.multivariate_values,
)
return
update_flag(experiment.environment, experiment.feature, change_set)

Expand All @@ -638,11 +633,10 @@ def apply_experiment_rollout(experiment: Experiment, spec: RolloutSpec) -> None:
segment = _sync_rollout_segment(experiment, spec.rollout_percentage)
_update_rollout_in_place(
experiment,
FlagChangeSet(
FlagChangeSetOptionA(
author=spec.author,
enabled=spec.enabled,
feature_state_value=spec.feature_state_value,
type_=spec.value_type,
value=FeatureValue(spec.feature_state_value, spec.value_type),
segment_id=segment.id,
multivariate_values=spec.multivariate_values,
),
Expand Down Expand Up @@ -699,11 +693,10 @@ def enable_experiment_rollout(experiment: Experiment, author: AuthorData) -> Non
value = rollout["feature_state_value"]
_update_rollout_in_place(
experiment,
FlagChangeSet(
FlagChangeSetOptionA(
author=author,
enabled=True,
feature_state_value=value["value"],
type_=value["type"],
value=FeatureValue(value["value"], value["type"]),
segment_id=experiment.rollout_segment_id,
),
)
Expand Down
Loading
Loading