Skip to content

fix: remove v0.1 experiment flag toggle from create feature modal #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove v0.1 experiment flag toggle from create feature modal #7907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63233b
fix: remove v0.1 experiment flag toggle from create feature modal
Zaimwa9 Jun 29, 2026
5f0cc53
chore: remove unused CreateExperimentModal
Zaimwa9 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 17 additions & 37 deletions frontend/web/components/feature-summary/FeatureRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React, { FC, useCallback, useEffect, useMemo } from 'react'
import ConfirmToggleFeature from 'components/modals/ConfirmToggleFeature'
import ConfirmRemoveFeature from 'components/modals/ConfirmRemoveFeature'
import CreateFlagModal from 'components/modals/create-feature'
import CreateExperimentModal from 'components/modals/create-experiment'

@talissoncosta talissoncosta Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still gonna keep CreateExperimentModal ?
Just checking to prevent dead code.

import ProjectStore from 'common/stores/project-store'
import Constants from 'common/constants'
import { useProtectedTags } from 'common/utils/useProtectedTags'
Expand Down Expand Up @@ -57,7 +56,6 @@ interface FeatureRowProps {
releasePipelines?: ReleasePipeline[]
onCloseEditModal?: () => void
isCompact?: boolean
experimentMode?: boolean
}

const width = [220, 50, 55, 70, 450]
Expand All @@ -69,7 +67,6 @@ const FeatureRow: FC<FeatureRowProps> = (props) => {
disableControls,
environmentFlags,
environmentId,
experimentMode = false,
fadeEnabled,
fadeValue,
hideAudit = false,
Expand Down Expand Up @@ -114,9 +111,9 @@ const FeatureRow: FC<FeatureRowProps> = (props) => {
const { feature } = Utils.fromParam()
const { id } = projectFlag

const isModalOpen =
!!document?.getElementsByClassName('create-feature-modal')?.length ||
!!document?.getElementsByClassName('create-experiment-modal')?.length
const isModalOpen = !!document?.getElementsByClassName(
'create-feature-modal',
)?.length
if (`${id}` === feature && !isModalOpen) {
editFeature()
}
Expand Down Expand Up @@ -202,35 +199,18 @@ const FeatureRow: FC<FeatureRowProps> = (props) => {
search: `?feature=${projectFlag.id}&tab=${tabValue}`,
})

const ModalComponent = experimentMode
? CreateExperimentModal
: CreateFlagModal
const modalCssClass = experimentMode
? 'side-modal create-feature-modal create-experiment-modal'
: 'side-modal create-feature-modal'

const modalProps = experimentMode
? {
environmentFlag,
environmentId,
history,
noPermissions: !permission,
projectFlag,
projectId,
tab,
}
: {
environmentFlag,
environmentId,
hasUnhealthyEvents:
isFeatureHealthEnabled && !!featureUnhealthyEvents?.length,
hideTagsByType: ['UNHEALTHY'],
history,
noPermissions: !permission,
projectFlag,
projectId,
tab,
}
const modalProps = {
environmentFlag,
environmentId,
hasUnhealthyEvents:
isFeatureHealthEnabled && !!featureUnhealthyEvents?.length,
hideTagsByType: ['UNHEALTHY'],
history,
noPermissions: !permission,
projectFlag,
projectId,
tab,
}

const ownerChips = enforceFeatureOwners
? [
Expand Down Expand Up @@ -273,8 +253,8 @@ const FeatureRow: FC<FeatureRowProps> = (props) => {
</div>
)}
</Row>,
<ModalComponent {...modalProps} />,
modalCssClass,
<CreateFlagModal {...modalProps} />,
'side-modal create-feature-modal',
() => {
if (onCloseEditModal) {
return onCloseEditModal()
Expand Down
210 changes: 0 additions & 210 deletions frontend/web/components/modals/create-experiment/ExperimentResultsTab.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading