fix: wait for config before rendering feature tables - #83
Merged
bakirFS merged 1 commit intoSep 14, 2026
Merged
Conversation
Since 1.2.0 flagsmithApp is loaded async in IssueFeatureTables but read synchronously on the first render, which throws on every issue with linked features. Load it in IssueFeaturesPanel with the other async data so the ready gate and setError cover it.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bakirFS
approved these changes
Sep 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.2.0 (#65) the issue panel crashes on any issue with a linked feature:
IssueFeatureTablesloadsflagsmithAppwithusePromise(readConfig, []), which isundefinedon the first render, but still doesconfig!.flagsmithApp. The tables are already non-empty on that render so it throws every time.Moved
readConfigintoIssueFeaturesPanelwith the other async calls, added it to thereadygate and passflagsmithAppdown. A failingreadConfignow goes throughsetErrorinstead of an unhandled rejection.