fix(gunicorn): respect GUNICORN_KEEP_ALIVE and GUNICORN_CMD_ARGS - #275
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
Estimated code review effort: 3 (Moderate) | ~20 minutes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 97.64% 97.66% +0.01%
==========================================
Files 110 110
Lines 4919 4958 +39
==========================================
+ Hits 4803 4842 +39
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 940a033c-d558-47de-b464-11963edaa294
📒 Files selected for processing (4)
src/common/core/cli/run.pysrc/common/gunicorn/utils.pytests/unit/common/core/test_run.pytests/unit/common/gunicorn/test_utils.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
11cfa28 to
06c8e7e
Compare
GUNICORN_KEEP_ALIVE, GUNICORN_CMD_ARGS and serve gunicorn argsGUNICORN_KEEP_ALIVE and GUNICORN_CMD_ARGS
`DjangoWSGIApplication.load_config` relies on `Config.get_cmd_args_from_env`, added in gunicorn 19.7. Raise the floor to the version we lock and test against, rather than another untested minimum.
Contributes to Flagsmith/flagsmith#8543.
GUNICORN_KEEP_ALIVE(default2).GUNICORN_CMD_ARGS, previously ignored. Precedence: defaults <GUNICORN_CMD_ARGS< CLI options.We also bump the gunicorn dependency constraint to an up-to-date value.