Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 97.64% 97.66% +0.01%
==========================================
Files 110 110
Lines 4919 4959 +40
==========================================
+ Hits 4803 4843 +40
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
DynamoDB reads numbers back as
Decimals, and validating a document read from DynamoDB changes them:Decimal("5"), becomes"5".Decimal("1"), becomesDecimal("1.0"), asDynamoInt | DynamoFloatpicks the float member.In this PR, we keep stored
Decimals as they are:DynamoIntandDynamoFloataccept a storedDecimalas is, andDynamoIntonly an integral one.validate_dynamo_feature_state_valuekeeps an integralDecimal.Validating Python values or JSON is unchanged, as is the JSON schema.
How did you test this code?
Added tests for stored
Decimals, and for validating each stored document twice. They fail without the fix.