Honor singular device= as an alias for devices= (fixes #907)#1584
Open
MushiSenpai wants to merge 1 commit into
Open
Honor singular device= as an alias for devices= (fixes #907)#1584MushiSenpai wants to merge 1 commit into
MushiSenpai wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. device= (singular) is silently swallowed by **kwargs, leaving devices=None, so get_target_devices(None) returns every visible GPU and the model OOMs across all of them (#907). device= is the singular many users reach for (e.g. from sentence-transformers).
Fix. In AbsEmbedder.init / AbsReranker.init, alias device=→devices= (with a one-line warning) when devices isn't set. Backward-compatible; explicit devices= wins; no dead attribute leak.
Test. tests/test_device_alias.py — model-free (no weights, no GPU).
Closes #907.
Drafted with AI assistance (Claude); reviewed, tested, and submitted by me.