Block fixed effects sharing refs - #83
Merged
Merged
Conversation
- Group same-refs terms into blocks and whiten each group with a rank-revealing transform (AbsorptionPlan); LSMR runs on the whitened operator, with exact handling of collinear interactions - Fuse gather/scatter kernels across block columns on CPU, CUDA, and Metal; thread the CPU adjoint gather - Support matrix right-hand sides in solve_residuals! - Reorganize benchmarks/ and add AKM worker-firm benchmarks - Bump version to 3.4.0
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage ? 66.39%
=======================================
Files ? 12
Lines ? 869
Branches ? 0
=======================================
Hits ? 577
Misses ? 292
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matthieugomez
force-pushed
the
block-absorption
branch
from
August 27, 2026 17:21
32a6378 to
86bac5b
Compare
matthieugomez
changed the title
Member
Author
|
|
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terms sharing the same refs (e.g. fe(id) + fe(id)&x) are now absorbed as one block, whitened per group with a rank-revealing transform, so LSMR handles collinear interactions exactly; for scalar fixed effects the operator is unchanged (identical iteration counts).