[FIRE-34340] Issue 2: Fix camavdist RLVa command to use impostors instead of jelly dolls - #275
Open
Atasly wants to merge 2 commits into
Open
[FIRE-34340] Issue 2: Fix camavdist RLVa command to use impostors instead of jelly dolls#275Atasly wants to merge 2 commits into
Atasly wants to merge 2 commits into
Conversation
Ansariel
reviewed
Aug 26, 2026
|
|
||
| if (visually_muted) | ||
| // <FS> FIRE-34340-2 Use getMutedAVColor() for all muted/complex/silhouette avatars | ||
| if (visually_muted || too_complex || rlv_silhouette) |
Collaborator
There was a problem hiding this comment.
Why include too complex avatars as well?
Contributor
Author
There was a problem hiding this comment.
Per your comment I realized I mistakenly switched two logic blobs while iterating over this issue.
The line you meant is indeed redundant/not needed, but the newly committed one is required for proper RLV silhouettes colorization.
if (visually_muted || too_complex || rlv_silhouette)
{
gGL.setColorMask(true, true);
}Apologies for the mishaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIRE-34340 Second Issue, i.e.
This issue has been opened a second one with FIRE-35778 which had been resolved with commit 86760e7
But I believe the original intent was to have the actual silhouette of an avatar, made pitch black, rendered through an impostor, instead of a jelly doll.
For reference, this is what RLV LSL documentation says:
I could not confirm original behaviour as non PBR FS viewer (6.6.17) already had the issue. I did not go further back in git history to track down the actual intended behaviour.
Any Impostors rendering issues are not fixed by this PR.
Furthermore, I would like to denote that the Third Issue from FIRE-34340 has been fixed or is at least not reproductible on my end.