Skip to content

[FIRE-34340] Issue 2: Fix camavdist RLVa command to use impostors instead of jelly dolls - #275

Open
Atasly wants to merge 2 commits into
FirestormViewer:masterfrom
Atasly:FIRE-34340-2
Open

[FIRE-34340] Issue 2: Fix camavdist RLVa command to use impostors instead of jelly dolls#275
Atasly wants to merge 2 commits into
FirestormViewer:masterfrom
Atasly:FIRE-34340-2

Conversation

@Atasly

@Atasly Atasly commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Fixes FIRE-34340 Second Issue, i.e.

Issue 2:
@camavdist:1=n hides avatars or turns them into slightly pixelated tiny blobs

This issue has been opened a second one with FIRE-35778 which had been resolved with commit 86760e7

But I believe the original intent was to have the actual silhouette of an avatar, made pitch black, rendered through an impostor, instead of a jelly doll.

For reference, this is what RLV LSL documentation says:

When active, this restriction makes all the avatars beyond <distance> look as if they were visually muted, but colored pitch black. 

I could not confirm original behaviour as non PBR FS viewer (6.6.17) already had the issue. I did not go further back in git history to track down the actual intended behaviour.
Any Impostors rendering issues are not fixed by this PR.

Furthermore, I would like to denote that the Third Issue from FIRE-34340 has been fixed or is at least not reproductible on my end.

Comment thread indra/newview/pipeline.cpp Outdated

if (visually_muted)
// <FS> FIRE-34340-2 Use getMutedAVColor() for all muted/complex/silhouette avatars
if (visually_muted || too_complex || rlv_silhouette)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why include too complex avatars as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per your comment I realized I mistakenly switched two logic blobs while iterating over this issue.
The line you meant is indeed redundant/not needed, but the newly committed one is required for proper RLV silhouettes colorization.

if (visually_muted || too_complex || rlv_silhouette)
{
    gGL.setColorMask(true, true);
}

Apologies for the mishaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants