[FIRE-34340] Issue 1: Fix camtextures and setcam_textures RLVa command for PBR materials. - #273
Open
Atasly wants to merge 2 commits into
Open
[FIRE-34340] Issue 1: Fix camtextures and setcam_textures RLVa command for PBR materials.#273Atasly wants to merge 2 commits into
Atasly wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIRE-34340 First Issue, i.e.
This fix also applies to the command
@setcam_textures:[uuid]=<y/n>This adds a second pass that iterates all volume prims and overrides the base color UUID on each PBR face's render material. Originals are tracked and restored when the command is removed/cleared.
It matches the Blinn-Phong behaviour.