Repository navigation
Read cached vertex serializers without acquiring the read lock - #578
Open
BonsUnleashed wants to merge 1 commit into
Open
BonsUnleashed wants to merge 1 commit into
BonsUnleashed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Every vertex-format copy looks up its serializer under a read lock, even after the cache has settled. This lets a cache hit read an immutable snapshot instead. A miss still takes the existing lock and refreshes the snapshot when the cache grows; serializer creation and its write lock stay as they are. The first lookup also includes serializers added by Oculus during construction.
This is the change used in Bons and Furious since 1.0.21. Its earlier checks covered concurrent readers and a writer and returned the same serializer objects. This upstream port passes
compileJavaon20.1/forge; I have not run this branch in game.