fix: IterChan.Next returns true on error events without storing a new value - #8
Open
childish-sambino wants to merge 1 commit into
Open
Conversation
childish-sambino
marked this pull request as ready for review
July 7, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a walk worker sends on
SendError,Next()stored the error and returned true without storing a new current value. Consumers callResource()on every iteration (file/uploader.go:176, file/downloader.go:127), so an error event either panics on the nil interface conversion (error before the first file, e.g. a file deleted between ReadDir and stat) or silently processes the previous entry twice.Next()now records the error forErr()and keeps waiting for the next value or Done, which is the contract consumers already assume (they checkit.Err()after the loop). The walker cancels the iterator context on exit (defer it.Stop()), so skipping error events can't hang the loop.🤖 Generated by Quad tha God