Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Treat upstream workflow_dispatch runs as trusted in build-push-container so manual r-build-check runs push a sha-tagged image and hand that exact ref to nextflow-test instead of falling back to master. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates to the Nextflow pipeline, focusing on parameter management, reproducibility, and workflow configuration. The most significant changes are the addition of new parameters (such as
asynchronous_updatesandseed), improved parameter passing and output tracking, and enhanced configuration for various compute environments. There are also clarifications and fixes in the workflow automation and documentation.Parameter handling and reproducibility:
seed(for reproducibility) andasynchronous_updates, and ensured they are passed throughout the workflow (main.nf,nextflow.config). [1] [2] [3]COGAPSto use a hash of key parameters, improving traceability of results. [1] [2]params.ymlfile in the output directory.Workflow and configuration enhancements:
nextflow.configto add and refine profiles for different compute environments (e.g.,jhpce,jhu_discovery,igs), including resource settings and queue options.resourceLimitsdefinition to use a closure, and adjusted CPU/memory allocations for high-resource processes. [1] [2]Workflow automation and documentation:
README.mdto reflect the new and reordered parameters, improving documentation accuracy.Dependency management:
sparseMatrixStatsR package is installed in the Docker image, supporting Nextflow module requirements.Code cleanup:
args) from process scripts for clarity and maintainability. [1] [2] [3]