ci: push sha-tagged image for all same-repo runs, not just master#155
Merged
Conversation
Copilot created this pull request from a session on behalf of
dimalvovs
June 7, 2026 15:00
View session
dimalvovs
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 (
nextflow-test) was always testing the stalemasterimage because stage 2 (build-push-container) only pushed/tagged onmasterpushes — all branch and PR builds produced no image in the registry, so the artifact fell back toghcr.io/…:master.Changes
build-push-container.ymlis_master_pushgate with acan_pushflag that istruefor all trusted contexts: same-repo branch pushes, same-repo PRs, andworkflow_dispatch. Fork PRs remain build-only (no secrets available).sha-<short>tag is pushed whenevercan_push=true;mastertag is added only on master pushes.sha-<short>ref when an image was pushed, so stage 3 tests the image just built rather than the stalemaster.IMAGE_NAMEchanged from${{ github.repository }}(produces mixed-caseFertigLab/CoGAPS) to the hardcoded lowercasefertiglab/cogaps, consistent withnextflow-test.yml.Fork PRs still fall back to
ghcr.io/fertiglab/cogaps:masterin the artifact, preserving the existing behaviour for untrusted contexts.