Skip to content

fix(bench): measure native-binary size from the published npm artifact#150

Merged
BryanFRD merged 1 commit into
mainfrom
fix/bench-binary-size-from-published
Jun 28, 2026
Merged

fix(bench): measure native-binary size from the published npm artifact#150
BryanFRD merged 1 commit into
mainfrom
fix/bench-binary-size-from-published

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

The "Native binary" size on the performance page came from the runner's local cargo build --release binary, while the npm size and all competitors come from a real npm install of the published package — so they weren't comparable (and the local binary measured larger than the npm install that contains it).

Measure the native binary from the published binary inside the npm package (@ferrflow/<platform>/bin/ferrflow), installed the same way as the npm footprint. Now both sizes describe the same published release, the binary is a subset of node_modules (so binary ≤ npm), and the column reflects what users actually run. Dead get_binary_size removed.

Validated on the next benchmark run (graceful N/A if the platform package is absent). bash -n clean; the bats suites test ferrflow_binary_size_mb as an input field and are unaffected.

Closes #149

@BryanFRD BryanFRD enabled auto-merge (squash) June 28, 2026 08:05
@BryanFRD BryanFRD merged commit 99f8950 into main Jun 28, 2026
13 checks passed
@BryanFRD BryanFRD deleted the fix/bench-binary-size-from-published branch June 28, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bench: native-binary size measured from local build, not the published artifact

1 participant