fix(bench): measure native-binary size from the published npm artifact#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Native binary" size on the performance page came from the runner's local
cargo build --releasebinary, while the npm size and all competitors come from a realnpm installof the published package — so they weren't comparable (and the local binary measured larger than the npm install that contains it).Measure the native binary from the published binary inside the npm package (
@ferrflow/<platform>/bin/ferrflow), installed the same way as the npm footprint. Now both sizes describe the same published release, the binary is a subset of node_modules (so binary ≤ npm), and the column reflects what users actually run. Deadget_binary_sizeremoved.Validated on the next benchmark run (graceful
N/Aif the platform package is absent).bash -nclean; the bats suites testferrflow_binary_size_mbas an input field and are unaffected.Closes #149