Skip to content

refactor(index): cache child process options - #606

Merged
Fdawgs merged 1 commit into
mainfrom
refactor/index-opts
Jul 17, 2026
Merged

refactor(index): cache child process options#606
Fdawgs merged 1 commit into
mainfrom
refactor/index-opts

Conversation

@Fdawgs

@Fdawgs Fdawgs commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Checklist

Copilot AI review requested due to automatic review settings July 17, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors src/index.js to reuse a shared child process options object (currently { windowsHide: true }) across spawnSync and spawn calls, aiming to reduce duplication and centralize configuration.

Changes:

  • Introduced CHILD_PROCESS_OPTS constant for common node:child_process options.
  • Replaced inline { windowsHide: true } objects in spawnSync calls with the shared constant.
  • Spread the shared options into the spawn options object to combine with signal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.js
@Fdawgs
Fdawgs merged commit a404629 into main Jul 17, 2026
21 checks passed
@Fdawgs
Fdawgs deleted the refactor/index-opts branch July 17, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants