Skip to content

test(index)!: use partialDeepStrictEqual#406

Open
Fdawgs wants to merge 1 commit into
mainfrom
test/index
Open

test(index)!: use partialDeepStrictEqual#406
Fdawgs wants to merge 1 commit into
mainfrom
test/index

Conversation

@Fdawgs
Copy link
Copy Markdown
Owner

@Fdawgs Fdawgs commented May 19, 2026

BREAKING CHANGE: minimum node version increased from 20 to 22.17.0

Not in a massive rush to merge this as it's just for tests and not functionality.

Checklist

Copilot AI review requested due to automatic review settings May 19, 2026 10:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the unit test suite to use Node’s assert.partialDeepStrictEqual via node:test, and aligns repository tooling with a higher minimum Node.js version.

Changes:

  • Replace the custom matchObject helper with t.assert.partialDeepStrictEqual in the unit test.
  • Bump the declared Node.js minimum version to >=22.17.0 and update local/dev tooling (.nvmrc, devcontainer).
  • Update CI to stop running tests on Node 20.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/index.test.js Removes custom subset assertion helper and uses partialDeepStrictEqual in the header assertion.
package.json Raises engines.node minimum to >=22.17.0.
.nvmrc Pins local Node version to 22.17.0.
.github/workflows/ci.yml Removes Node 20 from the unit test matrix.
.devcontainer/devcontainer.json Updates devcontainer base image from Node 20 to Node 22.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/index.test.js Outdated
Comment thread package.json
Comment thread .github/workflows/ci.yml
Comment thread .devcontainer/devcontainer.json
BREAKING CHANGE: minimum node version increased from 20 to 22.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants