Add gl_ES (Galician) locale - #1072
Open
apeleteiro wants to merge 1 commit into
Open
apeleteiro wants to merge 1 commit into
apeleteiro wants to merge 1 commit into
Conversation
pwsdotru
reviewed
Sep 24, 2026
| { | ||
| yield new Address($this->faker); | ||
|
|
||
| yield new Person($this->faker); |
There was a problem hiding this comment.
This is not mistake? For Address test needed Person information?
Author
There was a problem hiding this comment.
It's intentional: gl_ES\Address::$streetNameFormats uses {{firstName}} and {{lastName}}, which are provided by the Person provider. Without it, address() throws InvalidArgumentException: Unknown format "firstName", so testAddressIsSingleLine() needs it. pt_PT\AddressTest does the same for the same reason.
apeleteiro
marked this pull request as ready for review
September 24, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
Adds a new
gl_ESlocale for the Galician language (Galicia, Spain).New providers in
src/Provider/gl_ES/:Person: first names common in Galicia, mixing Spanish forms (Manuel, María, Josefa…) and traditional Galician forms (Xoán, Brais, Uxía, Sabela…), plus frequent Galician surnames. Names use two surnames, as is usual in Spain. Titles areSr./D./Dr.andSra./D.ª/Dra..dni()reuses thees_ESalgorithm;licenceCode()returns Spanish driving licence classes.Address: official Galician names of Galician municipalities (concellos), Galician street types (Rúa,Praza,Camiño,Rolda…), postcodes restricted to the four Galician provinces (15,27,32,36),state()returning A Coruña/Lugo/Ourense/Pontevedra, and country names in Galician.PhoneNumber: extendses_ES\PhoneNumber, with landlines restricted to the Galician prefixes981,982,986and988.Company: Galician company name formats (einstead ofy,e Fillos), typical prefixes (Conservas,Adegas,Obradoiro…) and suffixes (S.L.,S.A.,S.Coop.Galega).Internet: common email providers in Galicia and the.galTLD.Payment: extendses_ES\Payment(Spanish IBAN and CIF).Color: colour names in Galician.Tests added in
test/Provider/gl_ES/forPerson(DNI check letter, licence code, name format),Address(postcode, province, single-line address) andPhoneNumber(Galician prefix).Documentation PR: FakerPHP/fakerphp.github.io#133
Review checklist
CHANGELOG.md