[codex] Export ledger command types#354
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Summary
Root cause
Consumers need
CommandandDisclosedContract, but the publicledger-json-apibarrel only exportedTraceContext. That forced downstream SDKs to import from generatedbuild/src/...internals.Validation
npx prettier --check src/clients/ledger-json-api/index.ts test/unit/clients/ledger-json-api-exports.test.tsnpx jest test/unit/clients/ledger-json-api-exports.test.ts --runInBandnpm run build:coreafter initializinglibs/splicenpx jest test/unit --runInBandnpx eslint src/clients/ledger-json-api/index.ts test/unit/clients/ledger-json-api-exports.test.tsRepo-wide
npm run lintcurrently fails on unrelated existing files; this PR's changed files pass targeted ESLint.Note
Low Risk
Type-only public API expansion with no runtime or behavioral changes to ledger submission logic.
Overview
The
ledger-json-apipublic barrel now re-exports ledger JSON API command and submission types (Command,DisclosedContract,CommandRequest, variant command shapes,JsCommands, and related types) from./schemas, alongside the existingTraceContextexport. Consumers can import these from the package root instead of generatedbuild/src/...paths.A unit test asserts that
Command,DisclosedContract, andLedgerJsonApiClientresolve when imported from../../../src.Reviewed by Cursor Bugbot for commit 2ad8a46. Bugbot is set up for automated code reviews on this repo. Configure here.