Move ordinary task parameters into HIR - #98
Draft
OttoApocalypse69 wants to merge 5 commits into
Draft
Conversation
- Store ordered parameter semantics and spans in HIR snapshot v6\n- Route TY, MIR, and editor consumers through semantic adapters\n- Add boundary, restore, and invalidation smoke coverage
- Reject over-wide parameter records and impossible identifier facts - Enforce semantic span order before restoring editor and TY inputs - Extend adversarial and nonordinary boundary coverage
- Mutate a valid v6 parameter name to case-insensitive TRUE vocabulary\n- Require rejected restores to preserve the byte-identical HIR snapshot
- Register HIR v6 parameter snapshot and invalidation coverage - Guard ordinary TY adapters against syntax reconstruction - Preserve semantic parameter scopes through MIR and editor consumers
Place the ordinary parameter HIR check before the contract-region section it precedes.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this boundary
Parameter contracts are semantic signature facts. HIR owns their normalized source form and spans; TY interprets them, MIR build consumes their declaration/scope facts, and editor queries consume their definition spans. This removes another coherent syntax dependency without moving orchestration, snapshot coordination, or editor analysis into
freak_driver.Local validation
b5348a83bc4dec4822892c53a0d2fdef7801367e...8445f7fccb42175ffd3bb565d1655e2ec6c262ea, no P0-P3.python -u -m py_compile src/compiler/v4/check_v4.py freakc/auditor.pypython -u -m freakc audit-conformancepython -u src/compiler/v4/check_v4.py --fast: all 250 fixtures PASS; 3,775 flattened statements; 42.5 MB peak retained.git diff --checkPending CI/platform evidence
Conservative boundaries
This slice covers ordinary top-level task parameters only. Impl, doctrine, extern, closure/function-type, inferred, shape/route-field, const, and remaining MIR body type families remain explicit follow-up slices. It changes fact ownership, not language semantics or backend representation.