Fix V4 Windows runtime link contract - #97
Draft
OttoApocalypse69 wants to merge 1 commit into
Draft
Conversation
- Centralize runtime platform libraries for smoke and V3 links - Key compiler caches by platform, include path, and link arguments - Guard cross-platform mappings with an unconditional pure contract
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Generated runtime C references Winsock on Windows, but two checker paths omitted
-lws2_32; an external wrapper was masking the defect. Cache keys also omitted link policy, allowing stale pre-fix executables to bypass the repaired command.Local validation
a6e7de0060967e920a0fbfb7dcf3d65f225d49b3...b5348a83bc4dec4822892c53a0d2fdef7801367e: APPROVE, no P0-P3git diff --checktask return semantic boundarysmoke underGlobal\FreakCheckV4, no wrapper: runtime primitives, V3 stage0/stage2/final link+execute, and task-return native smoke all passedPending remote evidence
Boundaries
This is checker infrastructure only. It does not change the shipping compiler, runtime sources, native object-only links, target semantics, or PR readiness state.