Skip to content

Fix V4 Windows runtime link contract - #97

Draft
OttoApocalypse69 wants to merge 1 commit into
refactor/v4-no-syntax-task-returnsfrom
fix/v4-windows-runtime-link-contract
Draft

Fix V4 Windows runtime link contract#97
OttoApocalypse69 wants to merge 1 commit into
refactor/v4-no-syntax-task-returnsfrom
fix/v4-windows-runtime-link-contract

Conversation

@OttoApocalypse69

Copy link
Copy Markdown
Member

What changed

  • centralize checker platform runtime-link arguments
  • link Winsock on Windows, libm on Linux, and no extra runtime library on macOS/unknown hosts
  • apply the same policy to runtime smoke, LLVM runtime primitives, and V3 bootstrap stage0/stage2/final links
  • bind platform, include, runtime-link, and final-link policy into bumped compile-cache identities
  • add an unconditional fail-closed pure-Python platform/cache contract test

Why

Generated runtime C references Winsock on Windows, but two checker paths omitted -lws2_32; an external wrapper was masking the defect. Cache keys also omitted link policy, allowing stale pre-fix executables to bypass the repaired command.

Local validation

  • independent review of a6e7de0060967e920a0fbfb7dcf3d65f225d49b3...b5348a83bc4dec4822892c53a0d2fdef7801367e: APPROVE, no P0-P3
  • Python compile/import and direct link-policy self-test
  • git diff --check
  • serialized real-Clang task return semantic boundary smoke under Global\FreakCheckV4, no wrapper: runtime primitives, V3 stage0/stage2/final link+execute, and task-return native smoke all passed

Pending remote evidence

  • Linux/macOS native CI confirmation
  • automated review on the current head

Boundaries

This is checker infrastructure only. It does not change the shipping compiler, runtime sources, native object-only links, target semantics, or PR readiness state.

- Centralize runtime platform libraries for smoke and V3 links
- Key compiler caches by platform, include path, and link arguments
- Guard cross-platform mappings with an unconditional pure contract
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 360b9fd6-df93-44f9-9d47-9cb6e6b42853

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant