Store ordinary task returns in HIR - #96
Draft
OttoApocalypse69 wants to merge 2 commits into
Draft
Conversation
- Add closed task-return facts and HIR snapshot v5 validation\n- Make TY consume explicit ordinary returns without token reconstruction\n- Add focused boundary, snapshot, invalidation, and regression coverage
Trace ordinary explicit-return adapters through their bounded call closure and prove the guard rejects fallback indirection. Exercise return-only cache invalidation and semantic recomputation through HIR, TY, MIR, Meiya, and editor facts.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Ownership boundary
This is a bounded No Syntax Past HIR slice. HIR owns the normalized declared return fact; TY owns canonicalization and inference; MIR/Meiya/editor continue consuming TY APIs. Impl/doctrine/extern returns, arrow-expression inference, and implicit block inference remain explicit follow-up families.
Local validation
47c77abaeebfdf28e4e10c41d5f4665398fce838...a6e7de0060967e920a0fbfb7dcf3d65f225d49b3: APPROVE, no P0-P3python -u -m py_compile freakc/auditor.py src/compiler/v4/check_v4.pypython -u -m freakc audit-conformancetask return semantic boundarysmoke underGlobal\FreakCheckV4python -u src/compiler/v4/check_v4.py --fast: all 249 fixtures passed; 3,697 flattened statements; 40.7 MB peak retainedgit diff --checkPending remote evidence
Conservative boundaries