Fix ARM64 v0.14.1 concat release gate - #90
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe extra scaling test execution disables LeakSanitizer for the LLVM field-scaling fixture. Other scaling fixtures retain leak detection and AddressSanitizer checks. ChangesSanitizer scaling tests
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Member
Author
|
Merge gate @ ef8f587
Verdict: mergeable hotfix; v0.14.1 release stays blocked until tag workflow reruns green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the v0.14.1 Linux ARM64 release gate after tag workflow run 31610551154 exposed a platform-sensitive LeakSanitizer false failure.
The LLVM field-scaling concat fixture owns and clears its word field, but V3 intentionally has no shape-object release ABI. The sibling field-correctness fixture already preserves ASan memory-error checks while disabling only LeakSanitizer for this documented boundary. Apply the same narrowly scoped policy to the field-scaling fixture.
Evidence
Boundaries
The v0.14.1 release remains unpublished and blocked until this ready PR is reviewed, merged, and the tag workflow is rerun from the corrected main commit.
Summary by CodeRabbit