Skip to content

Fix ARM64 v0.14.1 concat release gate - #90

Merged
OttoApocalypse69 merged 1 commit into
mainfrom
fix/v0.14.1-arm64-concat-gate
Aug 12, 2026
Merged

Fix ARM64 v0.14.1 concat release gate#90
OttoApocalypse69 merged 1 commit into
mainfrom
fix/v0.14.1-arm64-concat-gate

Conversation

@OttoApocalypse69

@OttoApocalypse69 OttoApocalypse69 commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

Fix the v0.14.1 Linux ARM64 release gate after tag workflow run 31610551154 exposed a platform-sensitive LeakSanitizer false failure.

The LLVM field-scaling concat fixture owns and clears its word field, but V3 intentionally has no shape-object release ABI. The sibling field-correctness fixture already preserves ASan memory-error checks while disabling only LeakSanitizer for this documented boundary. Apply the same narrowly scoped policy to the field-scaling fixture.

Evidence

  • failing ARM64 job: exact archive, golden, negative, and ownership gates passed; only the LLVM field-scaling process failed on the known 8-byte shape allocation
  • fresh exact-head seed -> stage1 -> stage2 -> full CLI: PASS
  • tests/v3_word_concat.py against fresh CLI: PASS for C/LLVM normal, forced-move, global, and LLVM field scaling
  • concat audit remains exact: 8,192 append calls, 11 growths, 24,551 copied bytes
  • Python syntax and diff hygiene: PASS

Boundaries

  • This does not suppress LeakSanitizer for ordinary concat/ownership fixtures.
  • ASan remains enabled for the LLVM field fixture; only detect_leaks is disabled for the intentionally unreleasable containing shape.
  • No compiler, runtime, package, or release metadata changes.

The v0.14.1 release remains unpublished and blocked until this ready PR is reviewed, merged, and the tag workflow is rerun from the corrected main commit.

Summary by CodeRabbit

  • Tests
    • Updated scaling test execution to preserve AddressSanitizer memory-error checks for the LLVM field-scaling scenario.
    • Leak detection remains enabled for other scaling tests.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 09192148-b970-42d6-a079-e7882eca4a60

📥 Commits

Reviewing files that changed from the base of the PR and between ee4dbae and ef8f587.

📒 Files selected for processing (1)
  • tests/v3_word_concat.py

📝 Walkthrough

Walkthrough

The extra scaling test execution disables LeakSanitizer for the LLVM field-scaling fixture. Other scaling fixtures retain leak detection and AddressSanitizer checks.

Changes

Sanitizer scaling tests

Layer / File(s) Summary
LLVM field-scaling sanitizer configuration
tests/v3_word_concat.py
The LLVM field-scaling run disables leak detection because its shape allocation cannot be released. Other scaling runs keep leak detection enabled.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the ARM64 concat release-gate fix.
Description check ✅ Passed The description clearly covers the change, reason, validation evidence, scope, and reviewer boundaries, although it omits the template's Area and Checklist headings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v0.14.1-arm64-concat-gate

Comment @coderabbitai help to get the list of available commands.

@OttoApocalypse69

Copy link
Copy Markdown
Member Author

Merge gate @ ef8f587

  • Self-review: complete; one test-oracle file only; worktree clean and pushed head matches PR head.
  • Independent review: exact immutable head, no actionable P0-P3.
  • CodeRabbit: exact-head review complete, no actionable comments.
  • Focused validation: fresh self-host/full CLI and complete C/LLVM concat scaling suite pass.
  • CI: all applicable exact-head CodeQL, V3 platform, V4 fast, and V4 runtime checks green.
  • Review threads: 0.
  • Scope: only disables LSan for the known unreleasable LLVM field-shape allocation; ASan, ownership, concat audit, forced relocation, output, and linearity assertions remain active.

Verdict: mergeable hotfix; v0.14.1 release stays blocked until tag workflow reruns green.

@OttoApocalypse69
OttoApocalypse69 merged commit db2afbb into main Aug 12, 2026
21 checks passed
@OttoApocalypse69
OttoApocalypse69 deleted the fix/v0.14.1-arm64-concat-gate branch August 12, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant