Repository navigation
refactor(features): reorganize UI and use static group controls - #87
Merged
georgezakinih merged 3 commits intoSep 17, 2026
Merged
Conversation
zhan4329
marked this pull request as ready for review
September 15, 2026 19:40
georgezakinih
approved these changes
Sep 16, 2026
zhan4329
added a commit
to zhan4329/SPAC_Shiny
that referenced
this pull request
Sep 16, 2026
- update overview and PR summary to document PR FNLCR-DMAP#86 / FNLCR-DMAP#87 integration strategy - record combined baseline integration requirements in implementation notes - update task reassignment links to match renumbered PR plan entries
zhan4329
added a commit
to zhan4329/SPAC_Shiny
that referenced
this pull request
Sep 16, 2026
- mark PR FNLCR-DMAP#86 as merged into dev on 2026-09-16 in overview - add decision D21 recording completion of template delegation PR - update next steps to integrate PR FNLCR-DMAP#87 and point to Features facet tracker
zhan4329
added a commit
to zhan4329/SPAC_Shiny
that referenced
this pull request
Sep 16, 2026
- mark Tasks 3 (verification) and 4 (static Group By controls) complete - record postponement of Task 5 (shared styling) to cross-tab roadmap - add PR FNLCR-DMAP#87 summary covering changes, testing, and notes for review - update overview and implementation notes to coordinate PR FNLCR-DMAP#86 / FNLCR-DMAP#87 integration
zhan4329
added a commit
to zhan4329/SPAC_Shiny
that referenced
this pull request
Sep 16, 2026
- mark Tasks 3 (verification) and 4 (static Group By controls) complete - record postponement of Task 5 (shared styling) to cross-tab roadmap - add PR FNLCR-DMAP#87 summary covering changes, testing, and notes for review - update overview and implementation notes to coordinate PR FNLCR-DMAP#86 / FNLCR-DMAP#87 integration
- Group existing inputs into core, plot, and figure configuration sections. - Add a local disclosure helper while preserving input IDs, dynamic insertion targets, defaults, and server behavior. - Make the primary render action span the controls panel.
- Declare Annotation, Plot Together, and Stack Type in nested conditional UI. - Update Features annotation choices through the central effect updater. - Remove dynamic insertion state and effects while preserving histogram behavior.
zhan4329
force-pushed
the
ref/features-ui-structure
branch
from
September 16, 2026 16:40
12e16dd to
efc514b
Compare
zhan4329
added a commit
to zhan4329/SPAC_Shiny
that referenced
this pull request
Sep 16, 2026
- update overview with prerequisite PR FNLCR-DMAP#86 and PR FNLCR-DMAP#87 context and open issues - add decisions D2 (branch stacking) and D3 (inheriting UI structure) - detail template boundary, Together/Facet conflicts, and verification in notes - establish development-details tracker structure for facet implementation
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the SPAC Shiny Features tab into focused control and result components, organizes the existing inputs in
features_ui.pyinto clearer configuration sections, and replaces server-inserted Group By controls infeatures_server.pywith stable conditional UI infeatures_ui.py.The refactor preserves the current histogram behavior.
Related
Changes
_controls_panel()and_plot_panel(); Adds a local_collapsible_section()helper for presentation-only disclosure behavior.w-100in the button class.features_server.py.effect_update_server.py.Testing
python tests/test_utils/test_plot_utils.py -v—6 passedin the project Docker image.git diff --check dev...HEADpassed.Notes for Review
Suggested review order:
ui/features_ui.pyfor the extracted composition, disclosure sections, and static conditional controls.server/effect_update_server.pyfor centralized Annotation choices.server/features_server.pyfor removal of the dynamic UI lifecycle while retaining the existing render arguments.The static dependent inputs retain their selections while hidden; the renderer ignores them whenever Group By is disabled.
A better reusable cross-tab visualization design (and CSS styling) are postponed.
Screenshots
The new collapsible UI looks like this: