Repository navigation
chore(deps): pin SPAC to PR #433 and restore template compatibility - #85
Merged
Merged
Conversation
Update requirements.txt and environment.yml to use f9886bcde643ebf14e58a31d5ac397e28b6ea510.
Adapt the Ripley L and nearest-neighbor Shiny server callers to the SPAC PR #433 template API. - Import Ripley from visualize_ripley_l_template. - Replace save_results=False with save_to_disk=False.
3 of 7 tasks
georgezakinih
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates SPAC Shiny to the official SPAC merge commit containing FNLCR-DMAP/SCSAWorkflow#433's histogram-facet follow-up and updates the existing Ripley L and nearest neighbor callers to the pinned template API.
The change establishes a reproducible SPAC dependency baseline and removes the startup/runtime incompatibilities caused by the pinned package. Later features template adaptation and facet UI exposure will be developed on this PR.
Related PRs
FNLCR-DMAP/SCSAWorkflow#433
Changes
f9886bcde643ebf14e58a31d5ac397e28b6ea510in bothrequirements.txtandenvironment.yml.spac.templates.visualize_ripley_l_template.save_results=Falseargument withsave_to_disk=Falsein the Ripley L and nearest neighbor callers.Testing
The repository has no focused automated tests for these server template callers, and
pytestwas unavailable in the local environment. Docker startup and the focused Shiny smoke tests were used as the runtime validation.Initially, pinning spac to the latest commit will cause a module import error. This is fixed by the following commit updating Ripley L module names.
Commit Scope
bb70f13 chore(deps): pin SPAC to PR #433 merge commit9d425c8 fix(server): update pinned template callers