fix: stop the Details tab repeating what the page header already says - #69
Merged
Conversation
"Installed: Yes" could never say anything else — server_detail redirects a
server that is still installing, so the row was decoration. Pulling that
thread, most of the card was a second copy of the header:
Name the <h1> two inches above it
Game Type header subtitle
Port header subtitle
Status the header badge — and worse, the badge is the one the poll
keeps current, so this copy went STALE the moment the server
changed state while you were looking at it
Installed always Yes, see above
What is left is what you cannot read anywhere else: the three switches, plus
Short Name — and that only when it differs from the display name, which is
the case worth pointing out (a custom-named instance whose Linux user is
something else). The card is titled Server Settings now, because that is what
it is.
Same thing in the Host card: "Public IP: 147.135.70.122" sat directly above
"Connect: 147.135.70.122:28960". The Connect row is the same address plus the
port AND the one you can click to copy, so Public IP now appears only while
the address is still resolving, where "resolving…" is real information.
Measured on a rendered page: the public IP went from appearing twice to once,
Status from twice to once, Installed and Game Type from once to not at all.
Port still appears twice and should — once as metadata, once inside the
copyable connect string.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.03% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (ee31427) 11957 5802 48.52% Head commit (1e44375) 11957 (+0) 5806 (+4) 48.56% (+0.03%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#69) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Installed: Yes" could never say anything else —
server_detailredirects a server that's still installing, so the row was pure decoration. Pulling that thread, most of the card turned out to be a second copy of the header:<h1>two inches aboveStatus was worse than redundant. The header badge is the one the poll keeps current; the table's copy was rendered once and never updated, so it went stale the moment the server changed state while you were looking at it.
What's left is what you can't read anywhere else — the three switches, plus Short Name only when it differs from the display name, which is the case actually worth surfacing (a custom-named instance whose Linux user is something else). The card is titled Server Settings now, because that's what it is.
Same pattern in the Host card
Public IP: 147.135.70.122sat directly aboveConnect: 147.135.70.122:28960. The Connect row is the same address plus the port and the one you can click to copy. Public IP now appears only while the address is still resolving, whereresolving…is real information.Measured, not guessed
Counting occurrences in a rendered page:
unit 839 · smoke 300 · rbac 65 · template_actions 7 · lint clean.
🤖 Generated with Claude Code