fix: name what "Auto-start on boot" actually is, and stop the commands card scrolling - #67
Merged
Merged
Conversation
…s card scrolling Two things noticed on the Details tab. ── "does it need autostart on boot when it uses monitor?" ──────────────────── A fair question, and the answer is that they are the same switch. The label implied a separate @reboot mechanism; there isn't one. set_autostart() adds or removes exactly `*/5 * * * * ./codserver monitor` and deliberately strips any legacy `@reboot ... start` line, because monitor keeps the server in its INTENDED state — the start lockfile survives a reboot, so monitor brings back a server that should be running, and leaves a deliberately-stopped one down. A `@reboot start` would force-start a server the operator had stopped. So the row now reads "Auto-start & recover (monitor, every 5 min)", and the tooltip spells out the behaviour including the part that matters: it will not restart something you stopped on purpose. No behaviour change — only the label was lying about the mechanism. ── The Supported Commands card ─────────────────────────────────────────────── A hard max-height:340px made it scroll inside a card with plenty of room beside it — the list was cut off at "skeleton" while Server Info next to it ran 130px further down. Removed: ~20 rows for a typical game sizes fine, and the page scrolls like every other card here. Worth noting, not changed: the toggle reflects a DATABASE column, while install_game_cron() writes the same monitor line independently at install time. Nothing reconciles them, so the switch can disagree with the crontab. Making it read the real cron is a bigger change and its own PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.08% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (25ea042) 11936 5756 48.22% Head commit (4774be7) 11936 (+0) 5765 (+9) 48.30% (+0.08%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#67) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things from the Details tab.
"Does it need autostart on boot when it uses monitor?"
Fair question — and they're the same switch. The label implied a separate
@rebootmechanism; there isn't one.set_autostart()adds or removes exactly:…and deliberately strips any legacy
@reboot … startline. The reasoning in that function is sound:monitorkeeps a server in its intended state. The start lockfile survives a reboot, so monitor brings back a server that should be running — and leaves a deliberately-stopped one down. An@reboot startwould force-start a server you had stopped on purpose.So the row now reads "Auto-start & recover (monitor, every 5 min)", and the tooltip spells out the behaviour including the part that matters — it won't restart something you stopped deliberately. No behaviour change; only the label was lying about the mechanism.
The Supported Commands card
A hard
max-height:340pxmade it scroll inside a card with room to spare beside it — the list cut off atskeletonwhile Server Info next to it ran ~130px further down. Removed. About 20 rows for a typical game sizes fine, and the page scrolls like every other card here.Noticed, deliberately not changed
The toggle reflects a database column, while
install_game_cron()writes the same monitor line independently at install time. Nothing reconciles the two, so the switch can disagree with the actual crontab — it would show Off while monitor is still scheduled, or vice versa. Making it read the real cron state is a bigger change and deserves its own PR. Say the word.smoke 297 · template_actions 7 · lint clean.
🤖 Generated with Claude Code